Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the usage of special characters in the passphrase #65

Closed
1 task done
dabitdev opened this issue Nov 7, 2018 · 2 comments
Closed
1 task done

Define the usage of special characters in the passphrase #65

dabitdev opened this issue Nov 7, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@dabitdev
Copy link
Collaborator

dabitdev commented Nov 7, 2018 •
edited
Loading

NOTE: For support questions, please use Stack Overflow.
This repository's issues are reserved for feature requests and bug reports.

I'm submitting a...

  • Feature request

Bug

It is safer to avoid the usage of the special characters for the passphrase.

#Side effects
Previous wallets created with special characters may not able to recover. It should be better to prevent the special characters in the creation flow not in the recovering.
@dabitdev dabitdev added the enhancement New feature or request label Nov 7, 2018
@Daniel-Wang
Copy link
Contributor

@dabitdev this is a really good find, right now, we are accepting all possible characters, including spaces, but that actually affects the way we recover from an encrypted phrase, so we should definitely figure out how to fix this one properly.

@Daniel-Wang
Copy link
Contributor

Fixed issue with spaces in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dabitdev @Daniel-Wang