Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't like my Java datapack files #564

Closed
tryashtar opened this issue Apr 12, 2024 · 3 comments
Closed

It doesn't like my Java datapack files #564

tryashtar opened this issue Apr 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@tryashtar
Copy link

I think the extension is overly eager to appear; it puts warnings whenever I'm looking at certain Java datapack files.

image

I get these warnings for anything in the particles or recipes folders, and any file named blocks.json or sounds.json.

@DaanV2
Copy link
Contributor

DaanV2 commented Apr 14, 2024

Don't think I can do much in the plugin itself.

You can deactivate the extension for the workspace. Or use the .mcignore file in the root folder to specify what to skip

Example: https://github.com/Blockception/VSCode-Bedrock-Development-Extension/blob/main/.mcignore

@DaanV2 DaanV2 closed this as completed Apr 14, 2024
@tryashtar
Copy link
Author

Sadly disabling it in a workspace isn't feasible for me :(
Is it out of the question to look for manifest.json to figure out where we are? This naive approach that just looks at a file or folder name causes other issues too, like if you make an entity named blocks.json all the warnings are wrong

@Kesuaheli
Copy link

+1

Would be very helpful to only get highlightings, autocompletions, warnings and errors when the behaviour pack or resource pack root folder contains a (valid?) manifest.json file.

Apart from colliding with JE data packs, I noticed the current approach also collides with other plain JSON files. Even when not on a Minecraft context at all.
A while ago I started to have this extention always disabled. Only enabling it when needed and immediately disable it globally again. I hope I dont have too tell you that this is not the way it should works, even so though it works ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants