Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etherscan broadcast api might get rate limited without throwing error #166

Closed
ghost opened this issue Feb 17, 2020 · 0 comments
Closed

Etherscan broadcast api might get rate limited without throwing error #166

ghost opened this issue Feb 17, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 17, 2020

It was possible for etherscan to seemly get an okay API response but have a result of "Max rate limit reached, please use API Key for higher rate limit" instead of a transaction ID.

We should check for their standard way of doing error handling:

code: 200
body: {
    "status": "0",
    "message": "NOTOK",
    "result": "Max rate limit reached, please use API Key for higher rate limit"
}
ghost pushed a commit that referenced this issue Feb 17, 2020
ghost pushed a commit that referenced this issue Feb 17, 2020
Raise a broadcast error if etherscan api error #166
@ghost ghost closed this as completed Mar 31, 2020
fuerve pushed a commit to fuerve/cert-issuer that referenced this issue Jun 17, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants