Process all basic blocks to make the sighash checks 'greedy' #267
Conversation
…level_in_export_tokens Change log level to debug in eth_token_service.py
Enable streaming of EIP-1559 related columns to blocks and transactions tables.
|
Sorry, I missed the actual fix I wanted to implement in my commit. This now contains a loop through the basic blocks adding all the hashes. This will may add more sighashes than there really are (I'm not sure everything that's a PUSH4 is actually a function) but it doesn't seem to miss any which works for the matching on contracts if the function comes through a proxy, which lots of contracts seem to implement. |
Add EIP-1559 columns
…_param Export Contracts: Fix cli args
# Conflicts: # docs/dockerhub.md
…_travisci Fix travis ci timeout
adds support for non-mainnet in etl stream
Add POA support
Lock version of libcst to fix build and tests
|
Thanks for the PR! Looking only at the 1st block could produce false negatives (some function sighashes will be missing), while looking at all blocks could product false positives (some function sighashes will be added mistakenly). The PR needs some test cases and comparison of results before and after to understand the impact I kindly request to add test cases that could surface false positives. |
bump python-dateutil
…_upgrade Limit python-dateutil major version in case of breaking changes
|
Any updates relating this issue/PR? |
Instead of processing just basic_block[0] I've looped through all the basic blocks this finds the sighashes for many more ERC20 contracts.
I think this also removed the limitation around proxies. I'm still building my knowledge around ETH so it may do so at the expense of introducing false positives.