This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Card declined() #277
Merged
Card declined() #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
commented
Sep 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make #630 easier. Just call
declined()on a trade object to change its state torejected. It will even stayrejectedif yourefresh()the trade.I intentionally did not make this generic for all states, because I don't think that's safe.
Let me know if there are other states that need to be overridden. I suspect there's only a small number of cases where there are race conditions (the Coinify API lagging behind the iSignThis iframe) we need to deal with.