This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Use text dataType for getFiatAtTime
#35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2015 20:20
Using JSON as the data type causes problems because the server transmits amounts back *with commas* if they are above 999 (e.g. `2,105.83`). This messes up the JSON parsing and causes `$.ajax` to throw an error even if the request comes back correctly and with the expected data.
|
Pending a fix on the backend, this could be a good solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using JSON as the dataType causes problems because the server transmits amounts back with commas if they are above 999 (e.g.
2,105.83). This messes up the JSON parsing and causes$.ajaxto throw an error even if the request comes back correctly and with the expected data.Noticed this when converting many BTC wallet amounts to fiat currency.