fix(interest): ts errors in redux saga

blockchain · May 27, 2020 · 034b4cb · 034b4cb
1 parent a142bc8
commit 034b4cb
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 14 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/interest/actions.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/interest/actions.ts
@@ -79,9 +79,10 @@ export const fetchInterestInstrumentsSuccess = (
 })
 
 // LIMITS
-export const fetchInterestLimits = (coin?: CoinType, currency?: FiatType) => ({
+export const fetchInterestLimits = (coin: CoinType, currency: FiatType) => ({
   type: AT.FETCH_INTEREST_LIMITS,
-  payload: { coin, currency }
+  coin,
+  currency
 })
 export const fetchInterestLimitsFailure = (
   error: string

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/interest/sagaRegister.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/interest/sagaRegister.ts
@@ -32,7 +32,6 @@ export default ({
       interestSagas.fetchInterestInstruments
     )
     yield takeLatest(
-      // @ts-ignore
       AT.FETCH_INTEREST_LIMITS,
       interestSagas.fetchInterestLimits
     )
@@ -42,7 +41,6 @@ export default ({
     )
     yield takeLatest(AT.FETCH_INTEREST_RATE, interestSagas.fetchInterestRate)
     yield takeLeading(
-      // @ts-ignore
       AT.FETCH_INTEREST_TRANSACTIONS,
       interestSagas.fetchInterestTransactions
     )

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/interest/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/interest/sagas.ts
@@ -85,8 +85,10 @@ export default ({
     }
   }
 
-  const fetchInterestLimits = function * ({ payload }) {
-    const { coin, currency } = payload
+  const fetchInterestLimits = function * ({
+    coin,
+    currency
+  }: ReturnType<typeof A.fetchInterestLimits>) {
     try {
       yield put(A.fetchInterestLimitsLoading())
       const response: ReturnType<typeof api.getInterestLimits> = yield call(
@@ -125,7 +127,9 @@ export default ({
     }
   }
 
-  const fetchInterestTransactions = function * ({ payload }) {
+  const fetchInterestTransactions = function * ({
+    payload
+  }: ReturnType<typeof A.fetchInterestTransactions>) {
     const { reset } = payload
     try {
       const nextPage = yield select(S.getTransactionsNextPage)

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/interest/types.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/interest/types.ts
@@ -2,7 +2,6 @@ import * as AT from './actionTypes'
 import {
   AccountTypes,
   CoinType,
-  FiatType,
   InterestAccountBalanceType,
   InterestAccountType,
   InterestEligibleType,
@@ -115,10 +114,6 @@ interface FetchInterestInstrumentsSuccess {
 
 // LIMITS
 
-interface FetchInterestLimits {
-  payload: { coin?: CoinType; currency?: FiatType }
-  type: typeof AT.FETCH_INTEREST_LIMITS
-}
 interface FetchInterestLimitsFailure {
   payload: { error: string }
   type: typeof AT.FETCH_INTEREST_LIMITS_FAILURE

diff --git a/packages/blockchain-wallet-v4/src/network/api/interest/index.ts b/packages/blockchain-wallet-v4/src/network/api/interest/index.ts
@@ -37,8 +37,8 @@ export default ({ nabuUrl, authorizedGet, authorizedPost }) => {
     })
 
   const getInterestLimits = (
-    ccy?: CoinType,
-    currency?: FiatType
+    ccy: CoinType,
+    currency: FiatType
   ): { limits: InterestLimitsType } =>
     authorizedGet({
       url: nabuUrl,