fix(Iframes): allow camera for jumio, remove sandbox attr from iframes

blockchain · Jul 24, 2018 · 1fd8b13 · 1fd8b13
1 parent d7d468d
commit 1fd8b13
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/CoinifyExchangeData/ISignThis/index.js b/packages/blockchain-wallet-v4-frontend/src/modals/CoinifyExchangeData/ISignThis/index.js
@@ -308,12 +308,7 @@ class ISignThisContainer extends Component {
         </TimerContainer>
         <ISXContainer>
           <IframeWrapper>
-            <ISignThisIframe
-              src={srcUrl}
-              sandbox='allow-same-origin allow-scripts allow-forms'
-              scrolling='yes'
-              id='isx-iframe'
-            />
+            <ISignThisIframe src={srcUrl} scrolling='yes' id='isx-iframe' />
           </IframeWrapper>
           <ButtonContainer>
             <Button

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/SfoxExchangeData/Jumio/template.success.js b/packages/blockchain-wallet-v4-frontend/src/modals/SfoxExchangeData/Jumio/template.success.js
@@ -9,7 +9,9 @@ const Container = styled.div`
   align-items: center;
   flex-direction: column;
 `
-const JumioFrame = styled.iframe`
+const JumioFrame = styled.iframe.attrs({
+  allow: 'camera'
+})`
   width: 80%;
   height: 450px;
   border-width: 1px;
@@ -25,12 +27,7 @@ const Success = props => {
 
   return (
     <Container>
-      <JumioFrame
-        src={jumioUrl}
-        sandbox='allow-same-origin allow-scripts allow-forms allow-popups'
-        scrolling='yes'
-        id='jumio'
-      />
+      <JumioFrame src={jumioUrl} scrolling='yes' id='jumio' />
     </Container>
   )
 }

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/SfoxExchangeData/Link/iframe.js b/packages/blockchain-wallet-v4-frontend/src/modals/SfoxExchangeData/Link/iframe.js
@@ -29,7 +29,6 @@ const iframe = props => (
           : { border: 'none', width: '100%', height: '40px' }
       }
       src={props.plaidUrl}
-      sandbox='allow-same-origin allow-scripts allow-forms allow-popups'
       scrolling='no'
       id='plaid'
     />

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/SfoxExchangeData/sift-science.js b/packages/blockchain-wallet-v4-frontend/src/modals/SfoxExchangeData/sift-science.js
@@ -58,12 +58,7 @@ class SiftScience extends Component {
 
     if (siftScienceEnabled) {
       return (
-        <SiftScienceIframe
-          src={url}
-          sandbox='allow-same-origin allow-scripts'
-          scrolling='no'
-          id='sift-science-iframe'
-        />
+        <SiftScienceIframe src={url} scrolling='no' id='sift-science-iframe' />
       )
     }
   }