fix(buy sell): checks for cancellable orders when a user opens

the buy sell modal
blockchain · Apr 12, 2022 · 2ccc2c8 · 2ccc2c8
1 parent c21bc12
commit 2ccc2c8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/sagas.ts
@@ -1791,7 +1791,19 @@ export default ({ api, coreSagas, networks }: { api: APIType; coreSagas: any; ne
     return bankAccount
   }
 
+  const cleanupCancellableOrders = function* () {
+    const order = S.getCancelableOrder(yield select())
+    if (order) {
+      yield call(api.cancelBSOrder, order)
+      yield put(A.fetchOrders())
+      yield take(A.fetchOrdersSuccess.type)
+    }
+  }
+
   const showModal = function* ({ payload }: ReturnType<typeof A.showModal>) {
+    // When opening the buy modal if there are any existing orders that are cancellable, cancel them
+    yield call(cleanupCancellableOrders)
+
     const { cryptoCurrency, orderType, origin } = payload
     let hasPendingOBOrder = false
     const latestPendingOrder = S.getBSLatestPendingOrder(yield select())

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/selectors.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/selectors.ts
@@ -200,6 +200,11 @@ export const getBSLatestPendingOrder = (state: RootState) =>
     return order.state === 'PENDING_CONFIRMATION' || order.state === 'PENDING_DEPOSIT'
   })
 
+export const getCancelableOrder = createSelector(getBSOrders, (ordersR) => {
+  const orders = ordersR.getOrElse([])
+  return orders.find((order) => order.state === 'PENDING_CONFIRMATION')
+})
+
 export const getBuyQuote = (state: RootState) => state.components.buySell.buyQuote
 
 export const getSellQuote = (state: RootState) => state.components.buySell.sellQuote