fix(prov-payment): use payment.build only for btc and bch

blockchain · Apr 19, 2021 · 4e57882 · 4e57882
1 parent 9d31a10
commit 4e57882
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/simpleBuy/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/simpleBuy/sagas.ts
@@ -939,8 +939,12 @@ export default ({
         Number(cryptoAmt),
         account.coin
       )
-      payment = yield payment.amount(paymentAmount)
-      payment = yield payment.build()
+      if (payment.coin === 'BTC' || payment.coin === 'BCH') {
+        payment = yield payment.build()
+      } else {
+        payment = yield payment.amount(paymentAmount)
+      }
+
       yield put(A.updatePaymentSuccess(payment.value()))
     } catch (e) {
       // eslint-disable-next-line

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/swap/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/swap/sagas.ts
@@ -392,8 +392,11 @@ export default ({
         BASE.coin,
         Number(swapAmountValues?.cryptoAmount)
       )
-      payment = yield payment.amount(paymentAmount)
-      payment = yield payment.build()
+      if (BASE.coin === 'BTC' || BASE.coin === 'BCH') {
+        payment = yield payment.build()
+      } else {
+        payment = yield payment.amount(paymentAmount)
+      }
       yield put(A.updatePaymentSuccess(payment.value()))
     } catch (error) {
       yield put(A.updatePaymentFailure(error))

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/Interest/DepositForm/selectors.ts b/packages/blockchain-wallet-v4-frontend/src/modals/Interest/DepositForm/selectors.ts
@@ -54,9 +54,9 @@ export const getData = (state: RootState) => {
       walletCurrency: ExtractSuccess<typeof walletCurrencyR>
     ) => {
       const depositFee =
-        coin in Erc20CoinsEnum
-          ? Number(propOr('0', 'fee', payment))
-          : Number(pathOr('0', ['selection', 'fee'], payment))
+        coin === 'BCH' || coin === 'BTC'
+          ? Number(pathOr('0', ['selection', 'fee'], payment))
+          : Number(propOr('0', 'fee', payment))
 
       const feeCrypto =
         coin in Erc20CoinsEnum