fix(brokerage): add some todos for converting strings to enums later …

…and removed some commented code

packages/blockchain-wallet-v4-frontend/src/data/components/swap/utils.ts

@@ -42,11 +42,6 @@ export const interpolatePrice = (
   amount: BigNumber
 ): number | string => {
   try {
-    // if (thisPrice.isGreaterThan(nextPrice)) throw new Error('Should be sorted')
-    // if (thisVol.isGreaterThan(nextVol)) throw new Error('Should be sorted')
-    // if (amount.isLessThan(thisVol) && amount.isGreaterThan(nextVol))
-    //   throw new Error('Amount should be between x[0] and x[1]')
-
     return amount
       .minus(thisVol)
       .times(nextPrice.minus(thisPrice).dividedBy(nextVol.minus(thisVol)))
@@ -64,7 +59,7 @@ export const getRate = (
   minor?: boolean
 ): number => {
   try {
-    for (var index = 0; index <= priceTiers.length; index++) {
+    for (let index = 0; index <= priceTiers.length; index += 1) {
       const priceTier = priceTiers[index]
       if (index === priceTiers.length - 1)
         return minor

packages/blockchain-wallet-v4/src/network/api/simpleBuy/types.ts

@@ -1,10 +1,5 @@
 import { CardNameType } from 'components/Form/CreditCardBox/model'
-import {
-  BeneficiaryType,
-  CoinType,
-  FiatType,
-  WalletCurrencyType
-} from 'core/types'
+import { BeneficiaryType, CoinType, FiatType, WalletCurrencyType } from 'core/types'
 import { BankDetails } from 'data/types'
 
 export type Everypay3DSResponseType = {
@@ -103,12 +98,7 @@ export type SBCardType = {
 
 export type SBCardPartnerType = 'EVERYPAY'
 
-export type SBCardStateType =
-  | 'PENDING'
-  | 'CREATED'
-  | 'ACTIVE'
-  | 'BLOCKED'
-  | 'FRAUD_REVIEW'
+export type SBCardStateType = 'PENDING' | 'CREATED' | 'ACTIVE' | 'BLOCKED' | 'FRAUD_REVIEW'
 
 export type SBPairsType = string
 
@@ -216,6 +206,7 @@ export type SBSellOrderType = ISBBuyOrderType & {
 }
 export type SBOrderType = SBBuyOrderType | SBSellOrderType
 
+// TODO: refactor this into an enum
 export type SBOrderStateType =
   | 'PENDING_CONFIRMATION'
   | 'PENDING_DEPOSIT'