fix(tracking): custodial vs. nc sell tracking

blockchain · Dec 28, 2020 · 5015caf · 5015caf
1 parent 70db4fd
commit 5015caf
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 4 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/simpleBuy/actions.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/simpleBuy/actions.ts
@@ -549,6 +549,9 @@ const getPayloadObjectForStep = (payload: StepActionsPayload) => {
         displayBack: payload.displayBack,
         addBank: payload.addBank
       }
+    case 'PREVIEW_SELL': {
+      return { step: payload.step, sellOrderType: payload.sellOrderType }
+    }
     case 'CHECKOUT_CONFIRM':
     case 'ORDER_SUMMARY':
     case 'CANCEL_ORDER':

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/simpleBuy/types.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/simpleBuy/types.ts
@@ -403,12 +403,15 @@ export type StepActionsPayload =
       step: 'PAYMENT_METHODS'
     }
   | { order?: SBOrderType; step: '3DS_HANDLER' }
+  | {
+      sellOrderType?: 'ACCOUNT' | 'CUSTODIAL'
+      step: 'PREVIEW_SELL'
+    }
   | {
       step:
         | 'ADD_CARD'
         | 'CC_BILLING_ADDRESS'
         | 'KYC_REQUIRED'
-        | 'PREVIEW_SELL'
         | 'UPGRADE_TO_GOLD'
     }
 

diff --git a/packages/blockchain-wallet-v4-frontend/src/middleware/matomoMiddleware.ts b/packages/blockchain-wallet-v4-frontend/src/middleware/matomoMiddleware.ts
@@ -75,9 +75,26 @@ const sanitizeEvent = (
               fiatCurrency: sbAction.fiatCurrency,
               pair: sbAction.pair ? sbAction.pair.pair : '',
               side: sbAction.orderType,
+              sellOrderType: sbAction.swapAccount?.type,
               step: sbAction.step
             })
           ]
+        case 'PREVIEW_SELL':
+          return [
+            nextCategory,
+            formatEvent({
+              step: sbAction.step,
+              sellOrderType: sbAction.sellOrderType
+            })
+          ]
+        case 'SELL_ORDER_SUMMARY':
+          return [
+            nextCategory,
+            formatEvent({
+              step: sbAction.step,
+              sellOrderType: sbAction.sellOrder.kind.direction
+            })
+          ]
         default:
           return [nextCategory, formatEvent(sbAction.step)]
       }
@@ -160,8 +177,7 @@ const matomoMiddleware = () => () => next => action => {
       !equals(nextEvent, lastEvent) &&
       !includes(nextAction, EVENT_ACTION_BLACKLIST)
     ) {
-      // console.info('EVENT', nextEvent)
-      // uncomment to assist with debugging
+      // console.info('EVENT', nextEvent) // uncomment to assist with debugging
       const frame = document.getElementById('matomo-iframe')
       frame &&
         // @ts-ignore

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/SimpleBuy/EnterAmount/Checkout/index.tsx b/packages/blockchain-wallet-v4-frontend/src/modals/SimpleBuy/EnterAmount/Checkout/index.tsx
@@ -61,7 +61,10 @@ class Checkout extends PureComponent<Props> {
     // TODO: sell
     // need to do kyc check
     if (formValues?.orderType === 'SELL') {
-      return this.props.simpleBuyActions.setStep({ step: 'PREVIEW_SELL' })
+      return this.props.simpleBuyActions.setStep({
+        step: 'PREVIEW_SELL',
+        sellOrderType: this.props.swapAccount?.type
+      })
     }
 
     if (isSddFlow) {