Skip to content

Commit

Permalink
feat(analytics): adding enums for coin and account
Browse files Browse the repository at this point in the history
  • Loading branch information
@pedroapfilho
pedroapfilho committed Jun 3, 2021
1 parent 1215864 commit 62b95a7
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 19 deletions.
63 changes: 45 additions & 18 deletions packages/blockchain-wallet-v4-frontend/src/middleware/analyticsMiddleware/index.ts
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import analytics from 'middleware/analyticsMiddleware/analytics'
import type { PageNamesType } from 'middleware/analyticsMiddleware/types'
import { AnalyticsKey, AnalyticsType } from 'middleware/analyticsMiddleware/types'
import {
AccountType,
AnalyticsKey,
AnalyticsType,
CoinType
} from 'middleware/analyticsMiddleware/types'
import {
getNetworkFee,
getOriginalTimestamp,
Expand Down Expand Up @@ -155,7 +160,7 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
case AT.components.interest.SET_COIN_DISPLAY: {
const { isCoinDisplayed } = action.payload

const fix = isCoinDisplayed ? 'CRYPTO' : 'FIAT'
const fix = isCoinDisplayed ? CoinType.CRYPTO : CoinType.FIAT

analytics.push(AnalyticsKey.AMOUNT_SWITCHED, {
analyticsType: AnalyticsType.EVENT,
Expand Down Expand Up @@ -297,10 +302,14 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const state = store.getState()
const inputCurrency = state.form.initSwap.values.BASE.coin
const inputType =
state.form.initSwap.values.BASE.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.BASE.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY
const outputCurrency = state.form.initSwap.values.COUNTER.coin
const outputType =
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY

analytics.push(AnalyticsKey.SWAP_ACCOUNTS_SELECTED, {
analyticsType: AnalyticsType.EVENT,
Expand All @@ -321,11 +330,15 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const inputAmount = Number(state.form.swapAmount.values.cryptoAmount)
const inputCurrency = state.form.initSwap.values.BASE.coin
const inputType =
state.form.initSwap.values.BASE.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.BASE.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY
const outputAmount = inputAmount * exchangeRate
const outputCurrency = state.form.initSwap.values.COUNTER.coin
const outputType =
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY

analytics.push(AnalyticsKey.SWAP_AMOUNT_ENTERED, {
analyticsType: AnalyticsType.EVENT,
Expand All @@ -352,10 +365,14 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const state = store.getState()
const inputCurrency = state.form.initSwap.values.BASE.coin
const inputType =
state.form.initSwap.values.BASE.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.BASE.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY
const outputCurrency = state.form.initSwap.values.COUNTER.coin
const outputType =
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY

analytics.push(AnalyticsKey.SWAP_AMOUNT_MAX_CLICKED, {
analyticsType: AnalyticsType.EVENT,
Expand All @@ -374,10 +391,14 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const state = store.getState()
const inputCurrency = state.form.initSwap.values.BASE.coin
const inputType =
state.form.initSwap.values.BASE.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.BASE.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY
const outputCurrency = state.form.initSwap.values.COUNTER.coin
const outputType =
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY

analytics.push(AnalyticsKey.SWAP_AMOUNT_MIN_CLICKED, {
analyticsType: AnalyticsType.EVENT,
Expand All @@ -393,7 +414,8 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
}
case AT.components.swap.CHANGE_BASE: {
const inputCurrency = action.payload.account.coin
const inputType = action.payload.account.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
const inputType =
action.payload.account.type === 'CUSTODIAL' ? AccountType.TRADING : AccountType.USERKEY

analytics.push(AnalyticsKey.SWAP_FROM_SELECTED, {
analyticsType: AnalyticsType.EVENT,
Expand All @@ -407,7 +429,8 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
}
case AT.components.swap.CHANGE_COUNTER: {
const inputCurrency = action.payload.account.coin
const inputType = action.payload.account.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
const inputType =
action.payload.account.type === 'CUSTODIAL' ? AccountType.TRADING : AccountType.USERKEY

analytics.push(AnalyticsKey.SWAP_RECEIVE_SELECTED, {
analyticsType: AnalyticsType.EVENT,
Expand All @@ -425,11 +448,15 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const inputAmount = Number(state.form.swapAmount.values.cryptoAmount)
const inputCurrency = state.form.initSwap.values.BASE.coin
const inputType =
state.form.initSwap.values.BASE.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.BASE.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY
const outputAmount = inputAmount * exchangeRate
const outputCurrency = state.form.initSwap.values.COUNTER.coin
const outputType =
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL' ? 'TRADING' : 'USERKEY'
state.form.initSwap.values.COUNTER.type === 'CUSTODIAL'
? AccountType.TRADING
: AccountType.USERKEY
const networkFeeInputAmount =
state.form.initSwap.values.BASE.type === 'CUSTODIAL'
? 0
Expand Down Expand Up @@ -469,8 +496,8 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const state = store.getState()
const accountType =
state.forms.requestCrypto.values.selectedAccount.type === 'CUSTODIAL'
? 'TRADING'
: 'USERKEY'
? AccountType.TRADING
: AccountType.USERKEY
const currency = state.forms.requestCrypto.values.selectedAccount.coin

analytics.push(AnalyticsKey.RECEIVE_CURRENCY_SELECTED, {
Expand All @@ -488,8 +515,8 @@ const analyticsMiddleware = () => (store) => (next) => (action) => {
const state = store.getState()
const accountType =
state.forms.requestCrypto.values.selectedAccount.type === 'CUSTODIAL'
? 'TRADING'
: 'USERKEY'
? AccountType.TRADING
: AccountType.USERKEY
const currency = state.forms.requestCrypto.values.selectedAccount.coin

analytics.push(AnalyticsKey.RECEIVE_DETAILS_COPIED, {
Expand Down
12 changes: 11 additions & 1 deletion packages/blockchain-wallet-v4-frontend/src/middleware/analyticsMiddleware/types.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ enum AnalyticsType {
VIEW = 'VIEW'
}

enum AccountType {
TRADING = 'TRADING',
USERKEY = 'USERKEY'
}

enum CoinType {
CRYPTO = 'CRYPTO',
FIAT = 'FIAT'
}

type BasePayload = {
analyticsType: AnalyticsType
id: string
Expand Down Expand Up @@ -259,4 +269,4 @@ type PageNamesType = '/home'

export type { AnalyticsPayload, PageNamesType }

export { AnalyticsKey, AnalyticsType }
export { AccountType, AnalyticsKey, AnalyticsType, CoinType }

1 comment on commit 62b95a7

@Taysirh
Copy link

@Taysirh Taysirh commented on 62b95a7 Jun 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6

Please sign in to comment.