feat: remove hard coding

blockchain · Dec 15, 2021 · 62e8a40 · 62e8a40
1 parent e41b7ea
commit 62e8a40
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 6 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/sagas.ts
@@ -825,15 +825,20 @@ export default ({ api, coreSagas, networks }: { api: APIType; coreSagas: any; ne
   const fetchBuyQuote = function* ({ payload }: ReturnType<typeof A.fetchBuyQuote>) {
     try {
       yield put(A.fetchQuoteLoading())
-      const { amount, pair } = payload
+      const { amount, pair, paymentMethod } = payload
+      let paymentMethodId
+
+      if (paymentMethod === BSPaymentTypes.BANK_TRANSFER) {
+        paymentMethodId = 'd74992e0-a462-4aeb-903e-fc8e9a11bb40'
+      }
 
       const quote: ReturnType<typeof api.getBuyQuote> = yield call(
         api.getBuyQuote,
         pair,
         'SIMPLEBUY',
         amount,
-        'BANK_TRANSFER',
-        'd74992e0-a462-4aeb-903e-fc8e9a11bb40'
+        paymentMethod,
+        paymentMethodId
       )
 
       yield put(A.fetchBuyQuoteSuccess({ quote }))
@@ -1121,7 +1126,13 @@ export default ({ api, coreSagas, networks }: { api: APIType; coreSagas: any; ne
           const pairReversed = `${pairArr[1]}-${pairArr[0]}`
 
           // TODO: the below code is breaking, need to add price which is equivalent to rate
-          yield put(A.fetchBuyQuote({ amount: '0', pair: pairReversed }))
+          yield put(
+            A.fetchBuyQuote({
+              amount: '0',
+              pair: pairReversed,
+              paymentMethod: BSPaymentTypes.FUNDS
+            })
+          )
         } else {
           yield put(A.fetchQuote({ amount: '0', orderType, pair: pair.pair }))
         }

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/slice.ts b/packages/blockchain-wallet-v4-frontend/src/data/components/buySell/slice.ts
@@ -213,6 +213,7 @@ const buySellSlice = createSlice({
       action: PayloadAction<{
         amount: string
         pair: BSPairsType
+        paymentMethod: BSPaymentTypes
       }>
     ) => {},
     fetchBuyQuoteFailure: (state, action: PayloadAction<string>) => {
@@ -523,6 +524,7 @@ const buySellSlice = createSlice({
       action: PayloadAction<{
         amount: string
         pair: BSPairsType
+        paymentMethod: BSPaymentTypes
       }>
     ) => {},
     startPollSellQuote: (

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/BuySell/CheckoutConfirm/index.tsx b/packages/blockchain-wallet-v4-frontend/src/modals/BuySell/CheckoutConfirm/index.tsx
@@ -30,7 +30,11 @@ class CheckoutConfirm extends PureComponent<Props> {
     if (this.props.flexiblePricingModel) {
       this.props.buySellActions.fetchBuyQuote({
         amount: this.props.order.inputQuantity,
-        pair: this.props.order.pair
+        pair: this.props.order.pair,
+        paymentMethod:
+          this.props.order.paymentType === undefined
+            ? BSPaymentTypes.FUNDS
+            : this.props.order.paymentType
       })
     } else {
       this.props.buySellActions.fetchQuote({

diff --git a/packages/blockchain-wallet-v4/src/network/api/buySell/index.ts b/packages/blockchain-wallet-v4/src/network/api/buySell/index.ts
@@ -344,7 +344,7 @@ export default ({
     pair: string,
     profile: 'SIMPLEBUY' | 'SIMPLETRADE' | 'SWAP_FROM_USERKEY' | 'SWAP_INTERNAL' | 'SWAP_ON_CHAIN',
     inputValue: string,
-    paymentMethod: 'FUNDS' | 'PAYMENT_CARD' | 'BANK_TRANSFER' | 'BANK_ACCOUNT',
+    paymentMethod: BSPaymentTypes,
     paymentMethodId?: string
   ): BuyQuoteType =>
     authorizedPost({