feat(sso): remove ts ignore from saga register

blockchain · Dec 11, 2021 · 6398023 · 6398023
1 parent 29356e2
commit 6398023
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/auth/sagaRegister.ts b/packages/blockchain-wallet-v4-frontend/src/data/auth/sagaRegister.ts
@@ -18,8 +18,6 @@ export default ({ api, coreSagas, networks }) => {
     yield takeLatest(actions.initializeLogin.type, authSagas.initializeLogin)
     yield takeLatest(actions.triggerWalletMagicLink.type, authSagas.triggerWalletMagicLink)
     yield takeLatest(actions.getUserGeoLocation.type, authSagas.getUserGeoLocation)
-    // @ts-ignore
-    yield takeLatest(actions.loginRoutine.type, authSagas.loginRoutineSaga)
     yield takeLatest(actions.exchangeLogin.type, authSagas.exchangeLogin)
     yield takeLatest(actions.exchangeResetPassword.type, authSagas.exchangeResetPassword)
     yield takeLatest(actions.continueLoginProcess, authSagas.continueLoginProcess)

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/auth/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/auth/sagas.ts
@@ -23,6 +23,7 @@ import {
   pollForSessionFromGuid
 } from './sagas.utils'
 import * as S from './selectors'
+import { actions as A } from './slice'
 import {
   AccountUnificationFlows,
   LoginErrorType,

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/auth/slice.ts b/packages/blockchain-wallet-v4-frontend/src/data/auth/slice.ts
@@ -11,6 +11,7 @@ import {
   ExchangeResetPasswordFailureType,
   ExchangeResetPasswordSuccessType,
   LoginFailureType,
+  LoginRoutinePayloadType,
   LoginSuccessType,
   MetadataRestoreType,
   PlatformTypes,
@@ -137,7 +138,7 @@ const authSlice = createSlice({
     loginLoading: (state) => {
       state.login = Remote.Loading
     },
-    loginRoutine: () => {},
+    loginRoutine: (state, action: PayloadAction<LoginRoutinePayloadType>) => {},
     loginSuccess: (state, action: PayloadAction<LoginSuccessType>) => {
       state.login = Remote.Success(action.payload)
     },

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/auth/types.ts b/packages/blockchain-wallet-v4-frontend/src/data/auth/types.ts
@@ -59,12 +59,12 @@ export type RecoverFormType = {
   step: RecoverSteps
 }
 
-export type LoginPayloadType = {
-  code: string
-  guid: string
-  mobileLogin: boolean
-  password: string
-  sharedKey: string
+export type LoginRoutinePayloadType = {
+  country?: string
+  email?: string
+  firstLogin?: boolean
+  recovery?: boolean
+  state?: string
 }
 
 export type ExchangeLoginType = {

diff --git a/...lockchain-wallet-v4-frontend/src/scenes/Login/AccountUnification/UpgradeSuccess/index.tsx b/...lockchain-wallet-v4-frontend/src/scenes/Login/AccountUnification/UpgradeSuccess/index.tsx
@@ -30,7 +30,9 @@ const UpgradeSuccess = (props: Props) => {
             nature='primary'
             fullwidth
             height='48px'
-            onClick={() => props.authActions.loginRoutine()}
+            // commented out for now, undeeded until upgrade flows
+            // ReturnType on login routine saga
+            // onClick={() => props.authActions.loginRoutine()}
             data-e2e='iUnderstandWalletRedirect'
             style={{ marginTop: '16px' }}
           >