feat(NabuError): include id in nabu error analytics

Towards FWN-1742
blockchain · Jul 26, 2022 · a87fec1 · a87fec1
1 parent babeda1
commit a87fec1
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 1 deletion.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/analytics/types/errors.ts b/packages/blockchain-wallet-v4-frontend/src/data/analytics/types/errors.ts
@@ -25,6 +25,7 @@ export type ClientErrorProperties = {
   action?: string
   category?: string[]
   error: ErrorType
+  id?: string
   network_endpoint?: string
   network_error_code?: number
   network_error_description?: string

diff --git a/packages/blockchain-wallet-v4-frontend/src/services/errors/NabuError/NabuError.test.ts b/packages/blockchain-wallet-v4-frontend/src/services/errors/NabuError/NabuError.test.ts
@@ -17,6 +17,7 @@ describe('NabuError()', () => {
   })
 
   it('Should create a nabu error with all properties', () => {
+    const id = 'nabu_error_id'
     const title = 'Unable to quote USDC-USD'
     const message =
       "We are having problems fetching a quote for USDC-USD, don't worry - we're on it"
@@ -32,11 +33,13 @@ describe('NabuError()', () => {
 
     const error = new NabuError({
       icon,
+      id,
       message,
       title
     })
 
     expect(error.title).toEqual(title)
+    expect(error.id).toEqual(id)
     expect(error.message).toEqual(message)
     expect(error.icon).toEqual(icon)
   })

diff --git a/packages/blockchain-wallet-v4-frontend/src/services/errors/NabuError/NabuError.ts b/packages/blockchain-wallet-v4-frontend/src/services/errors/NabuError/NabuError.ts
@@ -1,6 +1,8 @@
 import { NabuErrorAction, NabuErrorIconProps, NabuErrorProps } from './NabuError.types'
 
 class NabuError extends Error {
+  id?: string
+
   title: string
 
   icon?: NabuErrorIconProps
@@ -11,9 +13,10 @@ class NabuError extends Error {
 
   actions?: NabuErrorAction[]
 
-  constructor({ actions, categories, icon, message, title }: NabuErrorProps) {
+  constructor({ actions, categories, icon, id, message, title }: NabuErrorProps) {
     super(title)
 
+    this.id = id
     this.title = title
     this.message = message
     this.categories = categories

diff --git a/packages/blockchain-wallet-v4-frontend/src/services/errors/NabuError/NabuError.types.ts b/packages/blockchain-wallet-v4-frontend/src/services/errors/NabuError/NabuError.types.ts
@@ -17,6 +17,7 @@ type NabuErrorProps = {
   actions?: NabuErrorAction[]
   categories?: string[]
   icon?: NabuErrorIconProps
+  id?: string
   message: string
   title: string
 }

diff --git a/...ror/utils/createNabuErrorAnalyticsInterceptor/createNabuErrorAnalyticsInterceptor.test.ts b/...ror/utils/createNabuErrorAnalyticsInterceptor/createNabuErrorAnalyticsInterceptor.test.ts
@@ -18,6 +18,7 @@ describe('createNabuErrorAnalyticsInterceptor()', () => {
     const dispatchSpy = jest.fn()
     const error = new NabuError({
       categories: ['TestCategory'],
+      id: 'nabu_error_id',
       message: 'Message',
       title: 'Error title'
     })
@@ -34,6 +35,7 @@ describe('createNabuErrorAnalyticsInterceptor()', () => {
         properties: {
           category: ['TestCategory'],
           error: 'NABU_ERROR',
+          id: error.id,
           network_error_description: error.message,
           network_error_type: 'NABU_ERROR',
           source: 'NABU',

diff --git a/...abuError/utils/createNabuErrorAnalyticsInterceptor/createNabuErrorAnalyticsInterceptor.ts b/...abuError/utils/createNabuErrorAnalyticsInterceptor/createNabuErrorAnalyticsInterceptor.ts
@@ -11,6 +11,7 @@ export const createNabuErrorAnalyticsInterceptor: CreateNabuErrorAnalyticsInterc
       const clientError: ClientErrorProperties = {
         category: error.categories,
         error: 'NABU_ERROR',
+        id: error.id,
         network_error_description: error.message,
         network_error_type: 'NABU_ERROR',
         source: 'NABU',