add logic to check if xlm address is exchange

blockchain · May 2, 2019 · a8ac55d · a8ac55d
1 parent e862169
commit a8ac55d
Show file tree

Hide file tree

Showing 9 changed files with 116 additions and 12 deletions.
diff --git a/config/mocks/wallet-options-v4.json b/config/mocks/wallet-options-v4.json
@@ -156,11 +156,48 @@
           "coinCode": "XLM",
           "coinTicker": "XLM",
           "colorCode": "xlm",
-          "displayName": "Stellar",
           "config": {
             "network": "public",
             "sendTimeOutSeconds": 10
           },
+          "displayName": "Stellar",
+          "exchangeAddresses": [
+            "GA4BYMUO5D7OLGVJWZ2D5FCWU7SB63FNZ4QUU574SMNA6ELK5TZD3SO3",
+            "GA5XIGA5C7QTPTWXQHY6MCJRMTRZDOSHR6EFIBNDQTCQHG262N4GGKTM",
+            "GABSZVZBYEO5F4V5LZKV7GR4SAJ5IKJGGOF43BIN42FNDUG7QPH6IMRQ",
+            "GAHK7EEG2WWHVKDNT4CEQFZGKF2LGDSW2IVM4S5DP42RBW3K6BTODB4A",
+            "GAW4E6NGM4NPNX2LO2BKDPCCTUX3FJLKWHPU4VQPGBIBQGD6JTVF5C7C",
+            "GAWPTHY6233GRWZZ7JXDMVXDUDCVQVVQ2SXCSTG3R3CNP5LQPDAHNBKL",
+            "GB3RMPTL47E4ULVANHBNCXSXM2ZA5JFY5ISDRERPCXNJUDEO73QFZUNK",
+            "GB6YPGW5JFMMP2QB2USQ33EUWTXVL4ZT5ITUNCY3YKVWOJPP57CANOF3",
+            "GB7GRJ5DTE3AA2TCVHQS2LAD3D7NFG7YLTOEWEBVRNUUI2Q3TJ5UQIFM",
+            "GBKTJSNUSR6OCXA5WDWGT33MNSCNQHOBQUBYC7TVS7BOXDKWFNHI4QNH",
+            "GBOEEVARKVASOQSSXCAHNTGJTVALJE2QM3AQQ2K3VXACQ6JJREQRJZKB",
+            "GBSTRH4QOTWNSVA6E4HFERETX4ZLSR3CIUBLK7AXYII277PFJC4BBYOG",
+            "GBSTRUSD7IRX73RQZBL3RQUH6KS3O4NYFY3QCALDLZD77XMZOPWAVTUK",
+            "GBTBVILDGCOIK26EPEHYCMKM7J5MTQ4FD5DO37GVTTBP45TVGRAROQHP",
+            "GBUQWP3BOUZX34TOND2QV7QQ7K7VJTG6VSE7WMLBTMDJLLAW7YKGU6EP",
+            "GBV4ZDEPNQ2FKSPKGJP2YKDAIZWQ2XKRQD4V4ACH3TCTFY6KPY3OAVS7",
+            "GBVOL67TMUQBGL4TZYNMY3ZQ5WGQYFPFD5VJRWXR72VA33VFNL225PL5",
+            "GBWZHAVWY23QKKDJW7TXLSIHY5EX4NIB37O4NMRKN2SKNWOSE5TEPCY3",
+            "GC4KAS6W2YCGJGLP633A6F6AKTCV4WSLMTMIQRSEQE5QRRVKSX7THV6S",
+            "GCGNWKCJ3KHRLPM3TM6N7D3W5YKDJFL6A2YCXFXNMRTZ4Q66MEMZ6FI2",
+            "GCLDH6L6FBLTD3H3B23D6TIFVVTFBLZMNBC3ZOI6FGI5GPQROL4FOXIN",
+            "GCNSGHUCG5VMGLT5RIYYZSO7VQULQKAJ62QA33DBC5PPBSO57LFWVV6P",
+            "GCO2IP3MJNUOKS4PUDI4C7LGGMQDJGXG3COYX3WSB4HHNAHKYV5YL3VC",
+            "GCVBUIXKKLH2DYHZRSLZUIZSVJUL74RTW6FVCCEYB2OE3RH7RVDBPCFG",
+            "GCXDR4QZ4OTVX6433DPTXELCSEWQ4E5BIPVRRJMUR6M3NT4JCVIDALZO",
+            "GDBCHKTHJUKDGSIQSTBUXFWVP3QVART5LED6KRZQ5X4Z5WLT4BGYXWCI",
+            "GDMXNQBJMS3FYI4PFSYCCB4XODQMNMTKPQ5HIKOUWBOWJ2P3CF6WASBE",
+            "GDRSWSKJCIB6Z65UA7W5RG62A7M5K3A5IHMED6DYHLPLWLVQCOOGDQ7S",
+            "GDU2FEL6THGGOFDHHP4I5FHNWY4S2SXYUBCEDB5ZREMD6UFRT4SYWSW2",
+            "GDZCEWJ5TVXUTFH6V5CVDQDE43KRXYUFRHKI7X64EWMVOVYYZJFWIFQ2",
+            "GDP34WXZRCSHVUDQLGKJKOBMS5LOQPHCIADZU5POEF3IICZ7XNQJ65Y6",
+            "GARAR5QR7WRL24MQMSO4INWV7C5SE4EE2YVXTLD6ORONYFHSUAGZYSLN",
+            "GCWYV4ZICBNDYJ3HE7GHPF3MJPIH63QNCWYPFTC5BQOIODUEI7HJBJVS",
+            "GDQP2KPQGKIHYJGXNUIYOMHARUARCA7DJT5FO2FFOOKY3B2WSQHG4W37",
+            "GBQ6RTEHEHXFPKSWCIM4KSVQXBANLFMVV6FJIZDLTF3ZOGFHTBDZUYDD"
+          ],
           "hasLockboxSupport": true,
           "icons": {
             "default": "xlm-circle-filled",

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/actionTypes.js b/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/actionTypes.js
@@ -13,6 +13,7 @@ export const SECOND_STEP_CANCEL_CLICKED =
   '@EVENT.SEND_XLM.SECOND_STEP_CANCEL_CLICKED'
 export const FIRST_STEP_TO_TOGGLED = '@EVENT.SEND_XLM.FIRST_STEP_TO_TOGGLED'
 export const FIRST_STEP_FEE_TOGGLED = '@EVENT.SEND_XLM.FIRST_STEP_FEE_TOGGLED'
+
 export const SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS =
   '@EVENT.SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS'
 export const SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_LOADING =
@@ -21,6 +22,16 @@ export const SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_SUCCESS =
   '@EVENT.SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_SUCCESS'
 export const SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_FAILURE =
   '@EVENT.SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_FAILURE'
+
+export const SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE =
+  '@EVENT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE'
+export const SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_LOADING =
+  '@EVENT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_LOADING'
+export const SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_SUCCESS =
+  '@EVENT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_SUCCESS'
+export const SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_FAILURE =
+  '@EVENT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_FAILURE'
+
 export const FIRST_STEP_PRIORITY_FEE_CLICKED =
   '@EVENT.SEND_XLM.FIRST_STEP_PRIORITY_FEE_CLICKED'
 export const FIRST_STEP_REGULAR_FEE_CLICKED =

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/actions.js b/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/actions.js
@@ -43,6 +43,21 @@ export const sendXlmCheckDestinationAccountExistsFailure = e => ({
   type: AT.SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_FAILURE,
   payload: e
 })
+export const sendXlmCheckIfDestinationIsExchange = address => ({
+  type: AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE,
+  payload: address
+})
+export const sendXlmCheckIfDestinationIsExchangeLoading = () => ({
+  type: AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_LOADING
+})
+export const sendXlmCheckIfDestinationIsExchangeSuccess = isExchange => ({
+  type: AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_SUCCESS,
+  payload: isExchange
+})
+export const sendXlmCheckIfDestinationIsExchangeFailure = e => ({
+  type: AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_FAILURE,
+  payload: e
+})
 export const firstStepFeeToggled = () => ({
   type: AT.FIRST_STEP_FEE_TOGGLED
 })

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/reducers.js b/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/reducers.js
@@ -5,6 +5,7 @@ import { Remote } from 'blockchain-wallet-v4/src'
 const INITIAL_STATE = {
   step: 1,
   checkDestination: Remote.NotAsked,
+  isDestinationExchange: Remote.NotAsked,
   payment: Remote.NotAsked,
   feeToggled: false,
   showNoAccountForm: false
@@ -36,6 +37,15 @@ export default (state = INITIAL_STATE, action) => {
     case AT.SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS_FAILURE: {
       return assoc('checkDestination', Remote.Failure(payload), state)
     }
+    case AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_LOADING: {
+      return assoc('isDestinationExchange', Remote.Loading, state)
+    }
+    case AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_SUCCESS: {
+      return assoc('isDestinationExchange', Remote.Success(payload), state)
+    }
+    case AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE_FAILURE: {
+      return assoc('isDestinationExchange', Remote.Failure(payload), state)
+    }
     case AT.FIRST_STEP_SUBMIT_CLICKED: {
       return assoc('step', 2, state)
     }

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/sagaRegister.js b/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/sagaRegister.js
@@ -25,6 +25,10 @@ export default ({ api, coreSagas }) => {
       AT.SEND_XLM_CHECK_DESTINATION_ACCOUNT_EXISTS,
       sendXlmSagas.checkDestinationAccountExists
     )
+    yield takeLatest(
+      AT.SEND_XLM_CHECK_IF_DESTINATION_IS_EXCHANGE,
+      sendXlmSagas.checkIfDestinationIsExchange
+    )
     yield takeLatest(actionTypes.CHANGE, sendXlmSagas.formChanged)
   }
 }
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/sagas.js b/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/sagas.js
@@ -91,8 +91,10 @@ export default ({ api, coreSagas }) => {
           payment = yield payment.to(value)
           // Do not block payment update when to is changed w/ destinationAccount check
           yield put(A.paymentUpdatedSuccess(payment.value()))
-          // After updating payment success check if destinationAccount exists
+          // check if destination exists
           yield put(A.sendXlmCheckDestinationAccountExists(value))
+          // check if destination is an exchange
+          yield put(A.sendXlmCheckIfDestinationIsExchange(value))
           return
         case 'amount':
           const xlmAmount = prop('coin', payload)
@@ -120,7 +122,7 @@ export default ({ api, coreSagas }) => {
     }
   }
 
-  const checkAccountExistance = function * (id) {
+  const checkAccountExistence = function * (id) {
     try {
       yield call(api.getXlmAccount, id)
       return true
@@ -129,11 +131,24 @@ export default ({ api, coreSagas }) => {
     }
   }
 
+  const checkIfDestinationIsExchange = function * ({ payload }) {
+    try {
+      yield put(A.sendXlmCheckIfDestinationIsExchangeLoading())
+      const exchangeAddresses = (yield select(
+        selectors.core.walletOptions.getXlmExchangeAddresses
+      )).getOrElse([])
+      const isExchange = includes(payload, exchangeAddresses)
+      yield put(A.sendXlmCheckIfDestinationIsExchangeSuccess(isExchange))
+    } catch (e) {
+      yield put(A.sendXlmCheckIfDestinationIsExchangeFailure(e))
+    }
+  }
+
   const checkDestinationAccountExists = function * ({ payload }) {
     try {
       yield put(A.sendXlmCheckDestinationAccountExistsLoading())
       const destinationAccountExists = yield call(
-        checkAccountExistance,
+        checkAccountExistence,
         payload
       )
 
@@ -310,6 +325,7 @@ export default ({ api, coreSagas }) => {
   return {
     initialized,
     checkDestinationAccountExists,
+    checkIfDestinationIsExchange,
     destroyed,
     firstStepSubmitClicked,
     maximumAmountClicked,

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/selectors.js b/packages/blockchain-wallet-v4-frontend/src/data/components/sendXlm/selectors.js
@@ -7,6 +7,11 @@ export const getCheckDestination = path([
   'sendXlm',
   'checkDestination'
 ])
+export const getIsDestinationExchange = path([
+  'components',
+  'sendXlm',
+  'isDestinationExchange'
+])
 export const getFeeToggled = path(['components', 'sendXlm', 'feeToggled'])
 export const showNoAccountForm = path([
   'components',

diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/Xlm/SendXlm/FirstStep/selectors.js b/packages/blockchain-wallet-v4-frontend/src/modals/Xlm/SendXlm/FirstStep/selectors.js
@@ -7,6 +7,7 @@ export const getData = createDeepEqualSelector(
   [
     selectors.components.sendXlm.getPayment,
     selectors.components.sendXlm.getCheckDestination,
+    selectors.components.sendXlm.getIsDestinationExchange,
     selectors.core.data.xlm.getTotalBalance,
     selectors.core.kvStore.lockbox.getLockboxXlmAccounts,
     selectors.core.settings.getCurrency,
@@ -19,6 +20,7 @@ export const getData = createDeepEqualSelector(
   (
     paymentR,
     checkDestinationR,
+    isDestinationExchangeR,
     balanceR,
     lockboxXlmAccountsR,
     currencyR,
@@ -32,6 +34,7 @@ export const getData = createDeepEqualSelector(
       'lockbox',
       coinAvailabilityR('XLM').getOrElse({})
     )
+    const destinationIsExchange = isDestinationExchangeR.getOrElse(false)
     const transform = (payment, currency, rates) => {
       const effectiveBalance = propOr('0', 'effectiveBalance', payment)
       const reserve = propOr('0', 'reserve', payment)
@@ -47,18 +50,19 @@ export const getData = createDeepEqualSelector(
 
       return {
         activeField,
+        balanceStatus: balanceR,
+        currency,
+        destination,
+        destinationAccountExists,
         effectiveBalance,
+        destinationIsExchange,
+        excludeLockbox,
         fee,
-        destination,
-        isDestinationChecked,
         from,
-        reserve,
-        currency,
-        rates,
-        destinationAccountExists,
-        balanceStatus: balanceR,
+        isDestinationChecked,
         noAccount,
-        excludeLockbox
+        rates,
+        reserve
       }
     }
     return lift(transform)(paymentR, currencyR, ratesR)

diff --git a/packages/blockchain-wallet-v4/src/redux/walletOptions/selectors.js b/packages/blockchain-wallet-v4/src/redux/walletOptions/selectors.js
@@ -53,6 +53,8 @@ export const getEthTxFuse = state =>
   getSupportedCoins(state).map(path(['ETH', 'lastTxFuse']))
 export const getXlmSendTimeOutSeconds = state =>
   getSupportedCoins(state).map(path(['XLM', 'config', 'sendTimeOutSeconds']))
+export const getXlmExchangeAddresses = state =>
+  getSupportedCoins(state).map(path(['XLM', 'exchangeAddresses']))
 export const getCoinAvailability = curry((state, coin) =>
   getSupportedCoins(state).map(path([toUpper(coin), 'availability']))
 )