Skip to content

Commit

Permalink
fix(analytics): add proerties to signup event
Browse files Browse the repository at this point in the history
  • Loading branch information
TheLeoB committed May 16, 2022
1 parent 25c9692 commit aacc672
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion config/mocks/wallet-options-v4.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"addStripePaymentProvider": false,
"coinViewV2": false,
"completeYourProfile": true,
"createExchangeUserOnSignupOrLogin": false,
"createExchangeUserOnSignupOrLogin": true,
"developerMobilePairing": true,
"eddInterestFileUpload": true,
"flexiblePricingModel": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,11 @@ type EmailVerifiedAction = {
type ExchangeSignedUpAction = {
key: Events.ONBOARDING_EXCHANGE_SIGNED_UP
properties: {
country: string
country_state: string
device_origin: string
origin?: string
unified?: boolean
}
}

Expand Down Expand Up @@ -241,9 +245,10 @@ type VerificationSubmissionFailedAction = {
type WalletSignedUpAction = {
key: Events.ONBOARDING_WALLET_SIGNED_UP
properties: {
country: string
country_state: string
country: String
country_state: String
device_origin: string
unified?: boolean
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export default ({ api, coreSagas, networks }) => {
}

yield put(actions.signup.registerSuccess(undefined))

yield put(
actions.analytics.trackEvent({
key: Analytics.ONBOARDING_WALLET_SIGNED_UP,
Expand All @@ -112,7 +113,10 @@ export default ({ api, coreSagas, networks }) => {
actions.analytics.trackEvent({
key: Analytics.ONBOARDING_EXCHANGE_SIGNED_UP,
properties: {
device_origin: platform
country,
country_state: `${country}-${state}`,
device_origin: platform,
unified: true
}
})
)
Expand Down

0 comments on commit aacc672

Please sign in to comment.