fix(KYC): updaetd email send flow

blockchain · Nov 30, 2018 · b0e235b · b0e235b
1 parent 42b3e6f
commit b0e235b
Show file tree

Hide file tree

Showing 11 changed files with 100 additions and 86 deletions.
diff --git a/...ges/blockchain-wallet-v4-frontend/src/data/components/identityVerification/actionTypes.js b/...ges/blockchain-wallet-v4-frontend/src/data/components/identityVerification/actionTypes.js
@@ -34,4 +34,4 @@ export const CREATE_REGISTER_USER_CAMPAIGN =
 export const CHECK_KYC_FLOW = '@EVENT.KYC.CHECK_KYC_FLOW'
 export const SET_KYCFLOW = '@DATA.KYC.SET_KYCFLOW'
 
-export const RESEND_DEEP_LINK = '@EVENT.RESEND_DEEP_LINK'
+export const SEND_DEEP_LINK = '@EVENT.SEND_DEEP_LINK'
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/identityVerification/actions.js b/packages/blockchain-wallet-v4-frontend/src/data/components/identityVerification/actions.js
@@ -79,6 +79,6 @@ export const setKycFlow = flowType => ({
   type: AT.SET_KYCFLOW,
   payload: { flowType }
 })
-export const resendDeeplink = () => ({
-  type: AT.RESEND_DEEP_LINK
+export const sendDeeplink = () => ({
+  type: AT.SEND_DEEP_LINK
 })
diff --git a/...es/blockchain-wallet-v4-frontend/src/data/components/identityVerification/sagaRegister.js b/...es/blockchain-wallet-v4-frontend/src/data/components/identityVerification/sagaRegister.js
@@ -32,6 +32,6 @@ export default ({ api, coreSagas }) => {
       exchange.createRegisterUserCampaign
     )
     yield takeLatest(AT.CHECK_KYC_FLOW, exchange.checkKycFlow)
-    yield takeLatest(AT.RESEND_DEEP_LINK, exchange.resendDeeplink)
+    yield takeLatest(AT.SEND_DEEP_LINK, exchange.sendDeeplink)
   }
 }
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/components/identityVerification/sagas.js b/packages/blockchain-wallet-v4-frontend/src/data/components/identityVerification/sagas.js
@@ -385,11 +385,11 @@ export default ({ api, coreSagas }) => {
     }
   }
 
-  const resendDeeplink = function*() {
+  const sendDeeplink = function*() {
     try {
-      yield call(api.resendDeeplink)
+      yield call(api.sendDeeplink)
     } catch (e) {
-      yield put(actions.logs.logErrorMessage(logLocation, 'resendDeeplink', e))
+      yield put(actions.logs.logErrorMessage(logLocation, 'sendDeeplink', e))
     }
   }
 
@@ -408,6 +408,6 @@ export default ({ api, coreSagas }) => {
     updateSmsNumber,
     verifySmsNumber,
     checkKycFlow,
-    resendDeeplink
+    sendDeeplink
   }
 }
diff --git a/...ages/blockchain-wallet-v4-frontend/src/data/components/identityVerification/sagas.spec.js b/...ages/blockchain-wallet-v4-frontend/src/data/components/identityVerification/sagas.spec.js
@@ -7,7 +7,7 @@ import sagas, { wrongFlowTypeError } from './sagas'
 
 const api = {
   fetchKycConfig: jest.fn(),
-  resendDeeplink: jest.fn()
+  sendDeeplink: jest.fn()
 }
 
 const coreSagas = {}

diff --git a/.../modals/Exchange/IdentityVerification/Verify/__snapshots__/template.highflow.spec.js.snap b/.../modals/Exchange/IdentityVerification/Verify/__snapshots__/template.highflow.spec.js.snap
@@ -79,7 +79,19 @@ exports[`HighFlow should render correctly 1`] = `
                 bold={false}
                 capitalize={false}
                 color="brand-secondary"
-                onClick={[MockFunction]}
+                onClick={
+                  [MockFunction] {
+                    "calls": Array [
+                      Array [],
+                    ],
+                    "results": Array [
+                      Object {
+                        "isThrow": false,
+                        "value": undefined,
+                      },
+                    ],
+                  }
+                }
                 size="16px"
                 uppercase={false}
                 weight={400}

diff --git a/...es/blockchain-wallet-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/index.js b/...es/blockchain-wallet-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/index.js
@@ -26,7 +26,7 @@ class VerifyContainer extends React.PureComponent {
         flowType === FLOW_TYPES.LOW ? (
           <LowFlow supportedDocuments={docTypes} {...rest} />
         ) : (
-          <HighFlow mobile={mobile} resend={actions.resendDeeplink} {...rest} />
+          <HighFlow mobile={mobile} send={actions.sendDeeplink} {...rest} />
         ),
       Loading: () => <Loading />,
       NotAsked: () => null,

diff --git a/...n-wallet-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/template.highflow.js b/...n-wallet-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/template.highflow.js
@@ -31,66 +31,75 @@ const VerifyWrapper = styled.div`
   `};
 `
 
-const Verify = ({ resend, onBack, mobile }) => (
-  <IdentityVerificationForm>
-    <FooterShadowWrapper
-      fields={
-        <VerifyWrapper>
-          <ColLeft>
-            <InputWrapper>
-              <IdentityVerificationHeader>
+class Verify extends React.PureComponent {
+  componentDidMount () {
+    this.props.send()
+  }
+
+  render () {
+    const { send, onBack, mobile } = this.props
+    return (
+      <IdentityVerificationForm>
+        <FooterShadowWrapper
+          fields={
+            <VerifyWrapper>
+              <ColLeft>
+                <InputWrapper>
+                  <IdentityVerificationHeader>
+                    <FormattedMessage
+                      id='identityverification.highflow.header'
+                      defaultMessage='Last Step. Continue your verification on mobile'
+                    />
+                  </IdentityVerificationHeader>
+                  <IdentityVerificationImage name='identity-verification' />
+                  <IdentityVerificationSubHeader>
+                    <Text>
+                      <FormattedMessage
+                        id='identityverification.highflow.message'
+                        defaultMessage='We need to confirm your identity by taking a selfie video'
+                      />
+                    </Text>
+                    <br />
+                    <Text>
+                      <FormattedMessage
+                        id='identityverification.highflow.sentlink'
+                        defaultMessage='- We just sent you an SMS to {mobile} with a link to complete KYC on your mobile device'
+                        values={{ mobile }}
+                      />
+                    </Text>
+                    <Text>
+                      <FormattedMessage
+                        id='identityverification.highflow.getidready'
+                        defaultMessage='- Get your ID or Passport ready'
+                      />
+                    </Text>
+                    <br />
+                    <Link onClick={send}>
+                      <FormattedMessage
+                        id='identityverification.highflow.resend'
+                        defaultMessage='Resend link'
+                      />
+                    </Link>
+                  </IdentityVerificationSubHeader>
+                </InputWrapper>
+              </ColLeft>
+            </VerifyWrapper>
+          }
+          footer={
+            <Footer>
+              <BackButton onClick={onBack}>
                 <FormattedMessage
-                  id='identityverification.highflow.header'
-                  defaultMessage='Last Step. Continue your verification on mobile'
+                  id='identityverification.personal.back'
+                  defaultMessage='Back'
                 />
-              </IdentityVerificationHeader>
-              <IdentityVerificationImage name='identity-verification' />
-              <IdentityVerificationSubHeader>
-                <Text>
-                  <FormattedMessage
-                    id='identityverification.highflow.message'
-                    defaultMessage='We need to confirm your identity by taking a selfie video'
-                  />
-                </Text>
-                <br />
-                <Text>
-                  <FormattedMessage
-                    id='identityverification.highflow.sentlink'
-                    defaultMessage='- We just sent you an SMS to {mobile} with a link to complete KYC on your mobile device'
-                    values={{ mobile }}
-                  />
-                </Text>
-                <Text>
-                  <FormattedMessage
-                    id='identityverification.highflow.getidready'
-                    defaultMessage='- Get your ID or Passport ready'
-                  />
-                </Text>
-                <br />
-                <Link onClick={resend}>
-                  <FormattedMessage
-                    id='identityverification.highflow.resend'
-                    defaultMessage='Resend link'
-                  />
-                </Link>
-              </IdentityVerificationSubHeader>
-            </InputWrapper>
-          </ColLeft>
-        </VerifyWrapper>
-      }
-      footer={
-        <Footer>
-          <BackButton onClick={onBack}>
-            <FormattedMessage
-              id='identityverification.personal.back'
-              defaultMessage='Back'
-            />
-          </BackButton>
-        </Footer>
-      }
-    />
-  </IdentityVerificationForm>
-)
+              </BackButton>
+            </Footer>
+          }
+        />
+      </IdentityVerificationForm>
+    )
+  }
+}
 
 Verify.propTypes = {
   handleSubmit: PropTypes.func.isRequired

diff --git a/...let-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/template.highflow.spec.js b/...let-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/template.highflow.spec.js
@@ -6,7 +6,7 @@ import HighFlow from './template.highflow'
 import { BackButton } from 'components/IdentityVerification'
 
 const onBack = jest.fn()
-const resend = jest.fn()
+const send = jest.fn()
 
 describe('HighFlow', () => {
   beforeEach(() => {
@@ -15,15 +15,15 @@ describe('HighFlow', () => {
 
   it('should render correctly', () => {
     const component = shallow(
-      <HighFlow mobile={'1234567890'} onBack={onBack} resend={resend} />
+      <HighFlow mobile={'1234567890'} onBack={onBack} send={send} />
     )
     const tree = toJson(component)
     expect(tree).toMatchSnapshot()
   })
 
   it('should trigger onBack on back button click', () => {
     const component = shallow(
-      <HighFlow mobile={'1234567890'} onBack={onBack} resend={resend} />
+      <HighFlow mobile={'1234567890'} onBack={onBack} send={send} />
     )
     component
       .find('FooterShadowWrapper')
@@ -33,15 +33,8 @@ describe('HighFlow', () => {
     expect(onBack).toHaveBeenCalledTimes(1)
   })
 
-  it('should trigger resend on resend link click', () => {
-    const component = shallow(
-      <HighFlow mobile={'1234567890'} onBack={onBack} resend={resend} />
-    )
-    component
-      .find('FooterShadowWrapper')
-      .dive()
-      .find('Link')
-      .simulate('click')
-    expect(resend).toHaveBeenCalledTimes(1)
+  it('should trigger email send on mount', () => {
+    shallow(<HighFlow mobile={'1234567890'} onBack={onBack} send={send} />)
+    expect(send).toHaveBeenCalledTimes(1)
   })
 })
diff --git a/...llet-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/template.lowflow.spec.js b/...llet-v4-frontend/src/modals/Exchange/IdentityVerification/Verify/template.lowflow.spec.js
@@ -47,7 +47,7 @@ describe('HighFlow', () => {
     expect(onBack).toHaveBeenCalledTimes(1)
   })
 
-  it('should trigger resend on resend link click', () => {
+  it('should trigger submit on submit click', () => {
     const component = shallow(
       <LowFlow
         supportedDocuments={supportedDocuments}

diff --git a/packages/blockchain-wallet-v4/src/network/api/kyc/index.js b/packages/blockchain-wallet-v4/src/network/api/kyc/index.js
@@ -68,11 +68,11 @@ export default ({ nabuUrl, get, post, authorizedGet, authorizedPost }) => {
       endPoint: '/kyc/configuration'
     })
 
-  const resendDeeplink = () =>
+  const sendDeeplink = () =>
     authorizedPost({
       url: nabuUrl,
       contentType: 'application/json',
-      endPoint: '/kyc/resendDeeplink'
+      endPoint: '/kyc/verifications/mobile-email'
     })
 
   return {
@@ -84,7 +84,7 @@ export default ({ nabuUrl, get, post, authorizedGet, authorizedPost }) => {
     fetchOnfidoSDKKey,
     fetchUploadData,
     syncOnfido,
-    resendDeeplink,
+    sendDeeplink,
     uploadDocuments
   }
 }