chore(prices): add types to multi-index api

blockchain · May 18, 2022 · c5bd0c0 · c5bd0c0
1 parent ba4197d
commit c5bd0c0
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 15 deletions.
diff --git a/packages/blockchain-wallet-v4-frontend/src/data/prices/sagas.ts b/packages/blockchain-wallet-v4-frontend/src/data/prices/sagas.ts
@@ -3,6 +3,7 @@ import { call, put, select } from 'redux-saga/effects'
 
 import { APIType } from '@core/network/api'
 import { selectors } from 'data'
+import { IndexMultiResponseType } from '@core/network/api/coin/types'
 
 import { actions as A } from './slice'
 import { CoinPricesRequestType } from './types'
@@ -23,7 +24,7 @@ export default ({ api }: { api: APIType }) => {
         base: coin,
         quote: fiatCurrency || defaultFiat
       }))
-      const data = yield call(api.getCoinPrices, request, timestamp)
+      const data: IndexMultiResponseType = yield call(api.getCoinPrices, request, timestamp)
       yield put(A.fetchCoinPricesSuccess(data))
     } catch (e) {
       yield put(A.fetchCoinPricesFailure(e.message))

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/prices/slice.ts b/packages/blockchain-wallet-v4-frontend/src/data/prices/slice.ts
@@ -6,15 +6,18 @@ import Remote from '@core/remote'
 import { CoinPricesRequestType, PricesStateType } from './types'
 
 const createPricesKvPairs = (prices) => {
-  return mergeAll(
-    map(
-      (x) => ({
-        // @ts-ignore
-        [x.split('-')[0]]: prices[x] ? prices[x] : null
-      }),
-      keys(prices)
-    )
-  )
+  return Object.keys(prices).reduce((pricesMap, priceKey) => {
+    const coinPrice = prices[priceKey]
+
+    if (!coinPrice) return pricesMap
+
+    const coinCode = priceKey.split('-')[0]
+
+    return {
+      ...pricesMap,
+      [coinCode]: coinPrice
+    }
+  }, {})
 }
 
 const initialState: PricesStateType = {

diff --git a/packages/blockchain-wallet-v4-frontend/src/data/prices/types.ts b/packages/blockchain-wallet-v4-frontend/src/data/prices/types.ts
@@ -1,9 +1,25 @@
 import { CoinType, RemoteDataType, WalletFiatType } from '@core/types'
 
-// TODO: type this!
+type CoinPrice = {
+  marketCap: number
+  price: number
+  timestamp: number
+  volume24h: number
+}
+
 export type PricesStateType = {
-  current: RemoteDataType<any, any>
-  previousDay: RemoteDataType<any, any>
+  current: RemoteDataType<
+    any,
+    {
+      [key: string]: CoinPrice
+    }
+  >
+  previousDay: RemoteDataType<
+    any,
+    {
+      [key: string]: CoinPrice
+    }
+  >
 }
 
 export type CoinPricesRequestType = {

diff --git a/...-v4-frontend/src/modals/BuySell/CryptoSelection/CryptoSelector/PriceMovement/selectors.ts b/...-v4-frontend/src/modals/BuySell/CryptoSelection/CryptoSelector/PriceMovement/selectors.ts
@@ -15,8 +15,8 @@ export const getData = createDeepEqualSelector(
       coinPrices: ExtractSuccess<typeof coinPricesR>,
       previousCoinPrices: ExtractSuccess<typeof coinPricesR>
     ) => {
-      const currentPrice = coinPrices[coin]
-      const yesterdayPrice = previousCoinPrices[coin]
+      const currentPrice = coinPrices[coin]?.price || 0
+      const yesterdayPrice = previousCoinPrices[coin]?.price || 0
       const priceChangeNum = Number(((currentPrice - yesterdayPrice) / yesterdayPrice) * 100)
       return Number.isNaN(priceChangeNum) ? '0' : priceChangeNum.toFixed(2)
     }