Improve txList processing #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plondon
commented
Jan 15, 2019
| TXNotes.selectNote(hash, Wallet.selectTxNotes(wallet)) || | ||
| getAddressLabel(to, state).getOrElse('') | ||
|
|
||
| const getPartnerLabel = hash => getBuySellTxHashMatch(state, hash) |
There was a problem hiding this comment.
Description/Label should possibly be moved to another service/selector
…page is still loading, fix pagi
|
@tony-blockchain need some help with the provider tests, the closest I got was in bch sagas spec, it's the state change test that is really tough. |
tony-blockchain
suggested changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to improve performance of txlist. This moves the processing logic from the selector to the saga.
Change Type
Please enter one or more of the following:
Testing Steps
Use a heavy wallet with a lot of transactions and accounts
Code Checklist
yarn start)README.mdand other documentation is updated as needed