Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Login IP whitelisting) #1383

Merged
merged 7 commits into from
Jan 28, 2019
Merged

Fix(Login IP whitelisting) #1383

merged 7 commits into from
Jan 28, 2019

Conversation

schnogz
Copy link
Contributor

@schnogz schnogz commented Jan 25, 2019

Description

  • Allows user to add more than two IPs to the whitelist (upto whatever 255 chars will allow)
  • Fixes issue were we attempted to save an empty list string as "null" or "undefined" to backend API which resulted in error shown to user
  • Removes some unneeded components
  • Standards and shorten some copy

Change Type

  • Bug Fix

Testing Steps

Detail the steps required for the reviewer(s) to verify and test these changes.

Code Checklist

  • Code compiles successfully (verified via yarn start)
  • README.md and other documentation is updated as needed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 35.136% when pulling 2eb5281 on fix/ip-whitelist into 0d7608e on development.

Copy link
Contributor

@plondon plondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI for the future, changing FormattedMessage ids will cost 💸

@plondon plondon merged commit 14ea3ea into development Jan 28, 2019
@plondon plondon deleted the fix/ip-whitelist branch January 28, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants