Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Selectors): upgraded selectors performance #1384

Merged
merged 3 commits into from
Jan 29, 2019
Merged

refactor(Selectors): upgraded selectors performance #1384

merged 3 commits into from
Jan 29, 2019

Conversation

tony-blockchain
Copy link
Contributor

@tony-blockchain tony-blockchain commented Jan 26, 2019 •
edited

Description

  1. fixed wrong createDeepEqualSelector usage
  2. added xlm selectors
  3. replaced ramda equals with fast-deep-equal

Change Type

Please enter one or more of the following:

  • Feature
  • Bug Fix
  • CI/CD
  • Upgrades
  • Other (add explanation)

Testing Steps

Detail the steps required for the reviewer(s) to verify and test these changes.

Code Checklist

  • Code compiles successfully (verified via yarn start)
  • README.md and other documentation is updated as needed

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 35.081% when pulling 118e0a7 on refactor/selectors_perf into 0d7608e on development.

@schnogz schnogz merged commit 40c3486 into development Jan 29, 2019
@schnogz schnogz deleted the refactor/selectors_perf branch January 29, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plondon plondon plondon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tony-blockchain @coveralls @plondon @schnogz