Fix(Camera staying on after QR code login) #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes
Im not entirely sure why this was happening, but it seems that having the
MobileLoginmodal added to the login template as well as added via theModalswrapper in theWalletLayoutcaused the QR code library we are using to never unmount properly thus it would cause camera to stay on and loop inside an error hook.I removed the
MobileLoginmodal from being added in theModalcomponents wrapper to avoid the above scenario.Change Type
Please enter one or more of the following:
Testing Steps
Detail the steps required for the reviewer(s) to verify and test these changes.
Code Checklist
yarn start)README.mdand other documentation is updated as needed