Feat(XLM memo exchanges) #1584
Merged
Feat(XLM memo exchanges) #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plondon
approved these changes
May 2, 2019
plondon
reviewed
May 3, 2019
| @@ -91,8 +91,10 @@ export default ({ api, coreSagas }) => { | |||
| payment = yield payment.to(value) | |||
| // Do not block payment update when to is changed w/ destinationAccount check | |||
| yield put(A.paymentUpdatedSuccess(payment.value())) | |||
| // After updating payment success check if destinationAccount exists | |||
| // check if destination exists | |||
There was a problem hiding this comment.
This specifically needs to happen after updating payment success. If thats clear enough then fine to remove
plondon
reviewed
May 3, 2019
| yield put(A.sendXlmCheckIfDestinationIsExchangeFailure(e)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There is no latency in this check so it should not follow Remote paradigm imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Testing Steps
Detail the steps required for the reviewer(s) to verify and test these changes.
Code Checklist
yarn start)README.mdand other documentation is updated as needed