Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Exclude Lockbox from ETH Erc20 fee calculation) #1599

Merged
merged 2 commits into from
May 8, 2019
Merged

Fix(Exclude Lockbox from ETH Erc20 fee calculation) #1599

merged 2 commits into from
May 8, 2019

Conversation

schnogz
Copy link
Contributor

@schnogz schnogz commented May 7, 2019

Description

  • Fixes issue where main wallet had PAX but no ETH (ETH was only in Lockbox) and the users were still able to attempt the transaction even though it would fail. This updates send and swap to use only main ETH address when determining if user has enough for erc20 tx fee

Change Type

  • Bug Fix

Testing Steps

Detail the steps required for the reviewer(s) to verify and test these changes.

Code Checklist

  • Code compiles successfully (verified via yarn start)
  • README.md and other documentation is updated as needed

@plondon plondon merged commit b9c5c1e into development May 8, 2019
@plondon plondon deleted the fix/disable-erc20-send-wo-eth branch May 8, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schnogz @plondon