wallet-options #245
Closed
wallet-options #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plondon
changed the title
plondon
commented
Apr 5, 2018
| @@ -4,6 +4,7 @@ const CleanWebpackPlugin = require('clean-webpack-plugin') | |||
| const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin') | |||
| const UglifyJSPlugin = require('uglifyjs-webpack-plugin') | |||
| const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin | |||
| const walletOptions = require('../Resources/wallet-options.json') | |||
|
|
|||
There was a problem hiding this comment.
@schnogz we could load the 4 wallet options here for each env then use some logic in the before function inside devServer to determine which walletOptions to return.
There was a problem hiding this comment.
Yeah that would work. I can lift some of the code from my environment PR into here to get that working.
|
Want to update the Websocket code to use the new ws endpoint info from wallet options call? It appears left out. |
|
Closing in favor of #243. |
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to remove hardcoded values that we should load from wallet-options. This fetches wallet-options at
Public/from '/Resources/wallet-options.json' then saves the url's for core onglobal..