feat(upgrade to gold): cleanup and added usage of constellation #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-bc
requested review from
blockdylanb,
TheLeoB,
jjBlockchain,
dkremniov-bc and
mvashchuk-bc
as code owners
blockdylanb
reviewed
Nov 11, 2022
| render() { | ||
| return <Template {...this.props} /> | ||
| } | ||
| const UpgradeToGold: React.FC<Props> = (props: Props) => { |
There was a problem hiding this comment.
since you're passing the Props to the React.FC already you don't need to do : Props in the big arrow func too.
blockdylanb
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (optional)
This PR just cleans up our component to prevent entire props spread and use constellation
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.