chore(refactor): start signup cleanup #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperdomo-bc
requested review from
TheLeoB,
milan-bc,
jjBlockchain,
dkremniov-bc,
mrodriguez-bc and
CTucker-BC
as code owners
mperdomo-bc
force-pushed
the
cleanup-signup
branch
from
562f89d
to
bee0f26
Compare
mperdomo-bc
commented
Jan 19, 2024
| @@ -208,11 +204,6 @@ const App = ({ | |||
| component={Signup} | |||
| pageTitle={`${BLOCKCHAIN_TITLE} | SoFi Signup`} | |||
| /> | |||
| <AuthLayout | |||
There was a problem hiding this comment.
This is duplicated by the route just above it, expand to confirm1
jjBlockchain
approved these changes
Jan 23, 2024
mperdomo-bc
added a commit
that referenced
this pull request
Jan 26, 2024
mperdomo-bc
added a commit
that referenced
this pull request
Jan 26, 2024
* chore(vars): remove unused vars (#6245) * chore(refactor): collocate sofi and auth type selectors (#6220) * chore(refactor): login convert to functional component (#6219) * feat(coinview): add notice about funds conversion (#6247) * chore(refactor): start signup cleanup (#6221) * chore(frictions): restructure frictions code (#6243) * Fiat remediation sell (#6248) * feat(sell): add conversion message * feat(sell): add hook & alert validation * feat(remediation): merge development * Fiat remediation deposit (#6249) * feat(deposit): add warning message * feat(deposit): refactor * feat(deposit): add message to deposit * feat(copy): update text * feat(remediation): correctly export new hook * chore(login): collocate state (#6250) * feat(sofi-referral): create redirect handler for migration + anon referral * feat(sofi-referral): add referral param * feat(sofi-referral): refine querystring * feat(sofi-referral): remove migration handler * chore(fix): reduce login footer rerenders (#6251) * chore(coinbox): do not rerender the coin box unnecessarily (#6252) * chore(rerender): fix sofi banner, header nav (#6253) * feat(sofi-referral): set referral cookie if the ref param is present (#6254) * chore(Release): v4.97.1 --------- Co-authored-by: mrodriguez-bc <mrodriguez@blockchain.com> Co-authored-by: Michael Rodriguez <88338953+mrodriguez-bc@users.noreply.github.com>
mperdomo-bc
added a commit
that referenced
this pull request
Jan 26, 2024
* chore(Release): v4.97.0 * Bump/v4.97.1 (#6255) * chore(vars): remove unused vars (#6245) * chore(refactor): collocate sofi and auth type selectors (#6220) * chore(refactor): login convert to functional component (#6219) * feat(coinview): add notice about funds conversion (#6247) * chore(refactor): start signup cleanup (#6221) * chore(frictions): restructure frictions code (#6243) * Fiat remediation sell (#6248) * feat(sell): add conversion message * feat(sell): add hook & alert validation * feat(remediation): merge development * Fiat remediation deposit (#6249) * feat(deposit): add warning message * feat(deposit): refactor * feat(deposit): add message to deposit * feat(copy): update text * feat(remediation): correctly export new hook * chore(login): collocate state (#6250) * feat(sofi-referral): create redirect handler for migration + anon referral * feat(sofi-referral): add referral param * feat(sofi-referral): refine querystring * feat(sofi-referral): remove migration handler * chore(fix): reduce login footer rerenders (#6251) * chore(coinbox): do not rerender the coin box unnecessarily (#6252) * chore(rerender): fix sofi banner, header nav (#6253) * feat(sofi-referral): set referral cookie if the ref param is present (#6254) * chore(Release): v4.97.1 --------- Co-authored-by: mrodriguez-bc <mrodriguez@blockchain.com> Co-authored-by: Michael Rodriguez <88338953+mrodriguez-bc@users.noreply.github.com> * Bump/v4.97.2 (#6259) * feat(sofi-referral): fix redirection * chore(Release): v4.97.2 --------- Co-authored-by: mrodriguez-bc <mrodriguez@blockchain.com> --------- Co-authored-by: mrodriguez-bc <mrodriguez@blockchain.com> Co-authored-by: Michael Rodriguez <88338953+mrodriguez-bc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.