chore(wire): use form state to allow user to proceed #6278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperdomo-bc
requested review from
TheLeoB,
milan-bc,
jjBlockchain,
dkremniov-bc,
mrodriguez-bc and
CTucker-BC
as code owners
jjBlockchain
previously approved these changes
Feb 8, 2024
| @@ -76,7 +60,7 @@ const EnterIntermediaryBank = ({ onClickBack, onNextStep }: StepProps) => { | |||
| data-e2e='intermediaryRoutingNumber' | |||
| name='intermediaryRoutingNumber' | |||
| noLastPass | |||
| validate={[required, validRoutingNumber, onlyNumbers]} | |||
| validate={[required, onlyNumbers, validRoutingNumber]} | |||
There was a problem hiding this comment.
👏 thank you for making this alphabetical order
There was a problem hiding this comment.
It really was because redux-form run this in order, and I'd first check that this is all numbers and then valid length, but that's a bonus
| const handleNext = () => { | ||
| if (disabled) return undefined | ||
| if (invalid) return undefined |
There was a problem hiding this comment.
we could just write return instead return undefined
jjBlockchain
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.