chore(refactor): refactor mobile modal & fix phone dropdown #6294
Conversation
mperdomo-bc
requested review from
TheLeoB,
milan-bc,
jjBlockchain,
dkremniov-bc,
mrodriguez-bc and
CTucker-BC
as code owners
| @@ -91,8 +92,6 @@ class PhoneNumberBox extends React.Component { | |||
| defaultCountry={countryCode} | |||
| preferredCountries={['us', 'gb']} | |||
| css={['intl-tel-input', 'form-control']} | |||
| utilsScript='libphonenumber.js' | |||
| placeholder='555-555-5555' | |||
There was a problem hiding this comment.
Removing the placeholder makes the component generate placeholders according to the selected country
There was a problem hiding this comment.
that is even better, we will have exact format based on the country 👍
| @@ -0,0 +1,43 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
Both MobileNumberAdd and MobileNumberChange are almost exactly the same, but due to them being used in different places sometimes and having custom analytics, I cannot merge them yet
| @@ -136,7 +136,7 @@ | |||
| "react-dropzone": "7.0.1", | |||
| "react-idle-timer": "5.2.0", | |||
| "react-intl": "5.24.4", | |||
| "react-intl-tel-input": "5.0.7", | |||
| "react-intl-tel-input": "8.2.0", | |||
| @@ -110,7 +109,7 @@ class PhoneNumberBox extends React.Component { | |||
| } | |||
|
|
|||
| PhoneNumberBox.propTypes = { | |||
| countryCode: PropTypes.object.isRequired | |||
| countryCode: PropTypes.string | |||
There was a problem hiding this comment.
I'm just curious was it really hard to migrate it to ts?
There was a problem hiding this comment.
Wanted to focus on the modals and then if necessary go through the components folder - always trying to balance the "make this repo better" with "this will be replaced not so far in the future"
|
New Issues
Fixed Issues
|
packages/blockchain-wallet-v4-frontend/src/modals/Mobile/MobileNumberAdd/template.tsx
Outdated
Show resolved
Hide resolved
|
I tested this on the staging but BE seems to fails when I try to add/update phone number with error 500. I did reported this, we should double check is all working before release |
No description provided.