Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(redux): convert modules/transferEth to slice #6296

Merged
merged 1 commit into from
Feb 22, 2024
Merged

chore(redux): convert modules/transferEth to slice #6296

merged 1 commit into from
Feb 22, 2024

Conversation

mperdomo-bc
Copy link
Collaborator

No description provided.

@sstephanou-bc
Copy link

Logo
Checkmarx One – Scan Summary & Details – 6a617af6-a50b-4bfc-ac2c-43cbd0db5631

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM SSRF /packages/blockchain-wallet-v4-frontend/src/data/analytics/analytics.ts: 10 Attack Vector
MEDIUM SSRF /packages/blockchain-wallet-v4-frontend/src/middleware/analyticsMiddleware/analytics.ts: 10 Attack Vector

Fixed Issues

Severity Issue Source File / Package
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4/src/walletCrypto/index.ts: 127
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4/src/walletCrypto/utils.js: 99
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/data/bitpay/sagas.js: 32
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4/src/walletCrypto/utils.js: 122
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/hooks/useSardine/useSardine.ts: 2
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/hooks/useSardine/useSardine.ts: 41
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/hooks/useSardine/useSardine.ts: 2
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/data/modules/profile/sagas.ts: 1
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/data/modules/profile/sagas.ts: 624
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /packages/blockchain-wallet-v4-frontend/src/data/modules/profile/sagas.ts: 1

milan-bc
milan-bc approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@milan-bc milan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, please do a testing cycle on pre prod before release 🙏

@mperdomo-bc mperdomo-bc merged commit 7fc497d into development Feb 22, 2024
2 checks passed
@mperdomo-bc mperdomo-bc deleted the redux-slice-modules-transfer-eth branch February 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-bc milan-bc milan-bc approved these changes

@TheLeoB TheLeoB Awaiting requested review from TheLeoB TheLeoB is a code owner

@jjBlockchain jjBlockchain Awaiting requested review from jjBlockchain jjBlockchain is a code owner

@dkremniov-bc dkremniov-bc Awaiting requested review from dkremniov-bc dkremniov-bc is a code owner

@mrodriguez-bc mrodriguez-bc Awaiting requested review from mrodriguez-bc mrodriguez-bc is a code owner

@CTucker-BC CTucker-BC Awaiting requested review from CTucker-BC CTucker-BC is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mperdomo-bc @sstephanou-bc @milan-bc