chore(redux): convert preferences to redux slice #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperdomo-bc
requested review from
TheLeoB,
milan-bc,
jjBlockchain,
dkremniov-bc,
mrodriguez-bc and
CTucker-BC
as code owners
mperdomo-bc
commented
Feb 21, 2024
| @@ -7,23 +7,21 @@ import { selectors } from 'data' | |||
| export const getData = createDeepEqualSelector( | |||
| [ | |||
| selectors.core.settings.getCurrency, | |||
| selectors.preferences.getPriceChart, | |||
| selectors.components.priceChart.getTime, | |||
There was a problem hiding this comment.
preferences.getPriceChart was updated, via the preferences reducer, with the same actions used in the priceChart reducer - so in this case the data obtained was exactly the same
|
No New Or Fixed Issues Found |
milan-bc
reviewed
Feb 22, 2024
milan-bc
reviewed
Feb 22, 2024
| @@ -78,7 +90,7 @@ class CryptoLinkHandlingContainer extends React.PureComponent { | |||
| <a | |||
| href='https://caniuse.com/?search=registerProtocolHandler' | |||
| target='_blank' | |||
| rel='noopener noreferrrer noreferrer' | |||
| rel='noopener noreferrer' | |||
mperdomo-bc
force-pushed
the
redux-slice-preferences
branch
from
82e26ff
to
4c8b569
Compare
jjBlockchain
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting the slight idea that many of these are not used - as they clash with some things that are in blockchain-wallet-v4-frontend/src/data/modules/settings/reducers.js