-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/testnet support #874
Fix/testnet support #874
Conversation
- Fixed config/index.js by renaming 'NETWORK' to 'NETWORK_BITCOIN' - Setting network config conditionally by checking environment - Passing network from onSubmit function of Register component - Fixed a few linting issues
- Rebased development branch
- Rebased development branch
…emove btc reference in settings config
- Add fallbackFees when mempool/fees fails
@lzhuor thanks again for your help, heres the PR |
Thank you @plondon ! Greatly appreciate your help! |
@@ -61,19 +61,19 @@ export const fromKeys = (entryECKey, encKeyBuffer, typeId) => { | |||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if kvstore works with testnet addresses. Have you tried that @plondon ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually need to check this more because if I set a kvstore value (e.g for shapeshift state) then login breaks.
Note to self:
at fromObject (index.js:311)
at from (index.js:137)
at Function.push.../../node_modules/buffer/index.js.Buffer.from (index.js:149)
at magicHash (index.js:37)
at Object.verify (index.js:57)
at KVStoreEntry.js:136
at _curryN.js:34
at _arity.js:22
at KVStoreEntry.js:160
at _curryN.js:34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kvstore works now
Overall looks pretty good. Two feature requests though.
|
TODO
Description
Pull in network from wallet-options
Change Type
Feature
Added testnet support
Bug Fix
~~1. The var
network
is assigned withsettings.NETWORK_BITCOIN
but we are usingNETWORK
as the name inconfig/index.js
so its value is alwaysundefined
. RenamedNETWORK
asNETWORK_BITCOIN
network
as a param inactions.auth.register()
function~~Testing Steps
yarn start:testnet
Code Checklist
yarn start
)yarn lint
)yarn test
)README.md
and other documentation is updated as needed