Add binding for SHA256 ECDH #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulo-bc do I need to increase some version for this to be included into iOS? Obviously we don't want random changes like this to pop up downstream without us explicitly opting into it. |
|
Lgtm, but I only looked very superficially. This PR strictly adds the |
jackpooleybc
approved these changes
Sep 11, 2020
| @@ -254,6 +254,35 @@ public struct Key { | |||
| return PubKey(Data(bytes: bytes_out, count: Int(EC_PUBLIC_KEY_LEN)), network, compressed: true)! | |||
| } | |||
| } | |||
|
|
|||
| public func ecdh(pubKey: PubKey) -> Data? { | |||
There was a problem hiding this comment.
It might be nice to either make this throw or return a Result here which could provide specific error.
There was a problem hiding this comment.
Hm right, but this seems to be consistent with the rest of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.