Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tip data type to string #14

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Change tip data type to string #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mocks/transactions-mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const mockTransaction = {
'0xdcd2f242d04cf19bf4695606a4244da9c7ab1d7a71153bcc3010909294dcb633e14841e833f35de113f8400b9687f10b93a27d3940926ba434318a7fc639f986',
signer: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY',
nonce: 37,
tip: 0,
tip: '0',
timestamp: 1600000000000,
createdDate: '2022-08-25 23:42:49.006343',
}
Expand All @@ -25,7 +25,7 @@ export const mockTransactions = [
'0xdcd2f242d04cf19bf4695606a4244da9c7ab1d7a71153bcc3010909294dcb633e14841e833f35de113f8400b9687f10b93a27d3940926ba434318a7fc639f986',
signer: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY',
nonce: 33,
tip: 0,
tip: '0',
createdDate: '2022-08-25 22:49:21.987641',
},
{
Expand All @@ -37,7 +37,7 @@ export const mockTransactions = [
'0x4eb9be0d2604225259ca3a0f183d424122f0fc6e2694e5d2f161f1c82b14fd5079ca525f9d89b1dbbfce666cbcf4ee843787f07c15993a26cb87ca24573bc087',
signer: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY',
nonce: 32,
tip: 0,
tip: '0',
createdDate: '2022-08-25 22:49:21.96569',
},
]
Expand Down Expand Up @@ -105,7 +105,7 @@ mockTransaction1.nonce = 0
mockTransaction1.signature =
'0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'
mockTransaction1.signer = '5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM'
mockTransaction1.tip = 0
mockTransaction1.tip = '0'
mockTransaction1.method = 'set'
mockTransaction1.section = 'timestamp'

Expand All @@ -116,7 +116,7 @@ mockTransaction2.nonce = 4
mockTransaction2.signature =
'0x984c98e3d74fcc35ddc5397282d282dcfda496ae95cb98f4e7d6d22125ec1e7cf03dc3f6fab3add1763bec4b8ee01346b198804b4faaaa1b88d37c5dbc9ca98b'
mockTransaction2.signer = '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY'
mockTransaction2.tip = 0
mockTransaction2.tip = '0'
mockTransaction2.method = 'call'
mockTransaction2.section = 'timestamp'

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ink-substrate-explorer-api",
"version": "1.0.5",
"version": "1.0.6",
"description": "Ink Explorer is an application that provides Ink contracts related information on Substrate based blockchains.",
"author": "Blockcoders <engineering@blockcoders.io>",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion src/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ type Transaction {
signer: String
ss58: String
timestamp: Float!
tip: Int
tip: String
tokens: String
type: Int
version: Int
Expand Down
6 changes: 3 additions & 3 deletions src/transactions/entity/transaction.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ export class Transaction extends BaseEntity {
@Field(/* istanbul ignore next */ () => Int, { nullable: true })
nonce?: number

@Column('int')
@Field(/* istanbul ignore next */ () => Int, { nullable: true })
tip?: number
@Column()
@Field(/* istanbul ignore next */ () => String, { nullable: true })
tip?: string

@Column('int')
@Field(/* istanbul ignore next */ () => Int, { nullable: true })
Expand Down
2 changes: 1 addition & 1 deletion src/transactions/transactions.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class TransactionsService {
signature: signature.toString(),
signer: signer.toString(),
nonce: nonce.toNumber(),
tip: tip.toNumber(),
tip: tip.toString(),
timestamp,
version,
type: type,
Expand Down