Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/getAccessKey #26

Merged
merged 6 commits into from
Dec 27, 2021
Merged

Feature/getAccessKey #26

merged 6 commits into from
Dec 27, 2021

Conversation

AnnRiera
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

bzuker
bzuker reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@bzuker bzuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a couple of comments

src/near-rpc-provider.ts Outdated Show resolved Hide resolved
src/near-rpc-provider.ts Outdated Show resolved Hide resolved
src/near-rpc-provider.ts Outdated Show resolved Hide resolved
src/near-rpc-provider.ts Outdated Show resolved Hide resolved
src/responses.ts Outdated Show resolved Hide resolved
AnnRiera and others added 3 commits December 21, 2021 16:38
@AnnRiera @bzuker
Update src/near-rpc-provider.ts
c7507b7 
Camel case change

Co-authored-by: Brian Zuker <brianzuker@gmail.com>
@AnnRiera
Commnets of PR
69b0bd3
@AnnRiera
Merging changes
f748eb2
@AnnRiera AnnRiera requested a review from bzuker December 21, 2021 20:59
@AnnRiera AnnRiera linked an issue Dec 21, 2021 that may be closed by this pull request
Add getAccessKey #25
Closed
bzuker
bzuker approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@bzuker bzuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzuker bzuker merged commit ab0b19c into main Dec 27, 2021
@bzuker bzuker deleted the feature/getAccessKey branch December 27, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzuker bzuker bzuker approved these changes

@0xslipk 0xslipk Awaiting requested review from 0xslipk

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
Milestone 2 - FallbackProvider
Development

Successfully merging this pull request may close these issues.

Add getAccessKey
2 participants
@AnnRiera @bzuker