Fix #126: '_io.BufferedRandom' object has no attribute 'buffer' #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
dont_hack_codecs.getreader
branch
from
ea4c03c
to
14893db
Compare
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 22, 2020
* Update requirements from branch 'master'
- Merge "blacklist blockdiag 2.0.0"
- blacklist blockdiag 2.0.0
blockdiag has been used as an indirect dependcy via some sphinx
extensions such as sphinxcontrib-blockdiag and sphinxcontrib-actdiag
for several releases. For the past few releases nova has monkey
patched blockdiag to work around there global replacement
of codec.getreader under python 3.
The 2.0.0 release broke how that monkey patching worked and also
was the first release in several years. Now that the project is active
again we have reported the python 3 issue to the maintainer
blockdiag/blockdiag#126 and it
has been adressed by blockdiag/blockdiag#129
in 2.0.1 which has now been released.
https://pypi.org/project/blockdiag/2.0.1/
This change blacklists 2.0.0. This change does not raise the minimum
requirement. Nova can selectively raise its minimum requirement in the
future in tree if it chooses to remove support for monkey patching
older releases.
Other project are recommended to use 2.0.1 or later as this is the first
release which is python3 only and is compatible with the sphinx
extentions we use without monkey patching.
Change-Id: I414d9e604616d49b4456ebc348418e9b1b09058b
openstack-gerrit
pushed a commit
to openstack/requirements
that referenced
this pull request
Feb 22, 2020
blockdiag has been used as an indirect dependcy via some sphinx extensions such as sphinxcontrib-blockdiag and sphinxcontrib-actdiag for several releases. For the past few releases nova has monkey patched blockdiag to work around there global replacement of codec.getreader under python 3. The 2.0.0 release broke how that monkey patching worked and also was the first release in several years. Now that the project is active again we have reported the python 3 issue to the maintainer blockdiag/blockdiag#126 and it has been adressed by blockdiag/blockdiag#129 in 2.0.1 which has now been released. https://pypi.org/project/blockdiag/2.0.1/ This change blacklists 2.0.0. This change does not raise the minimum requirement. Nova can selectively raise its minimum requirement in the future in tree if it chooses to remove support for monkey patching older releases. Other project are recommended to use 2.0.1 or later as this is the first release which is python3 only and is compatible with the sphinx extentions we use without monkey patching. Change-Id: I414d9e604616d49b4456ebc348418e9b1b09058b
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
blockdiag has been used as an indirect dependcy via sphinx for several releases. For the past few releases nova has monkey patched blockdiag to around there global replacement of codec.getreader under python 3. The 2.0.0 release broke how that monkey patching worked and also was the first release in several years. Now that the project is active again we have reported the python 3 issue to the maintainer blockdiag/blockdiag#126 and it has been adressed by blockdiag/blockdiag#129 in 2.0.1 which has now been released. https://pypi.org/project/blockdiag/2.0.1/ This change blacklists 2.0.0. This change does not raise the minium requirement. Nova can selectively raise its minium requirement in the future in tree if it chooses too remove support for monkey patching older releases. Other project are recommended to use 2.0.1 or later as this is the first release which is python3 only and is compatiable with the sphinx extentions we use without monkey patching. Change-Id: I414d9e604616d49b4456ebc348418e9b1b09058b
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
blockdiag has been used as an indirect dependcy via some sphinx extensions such as sphinxcontrib-blockdiag and sphinxcontrib-actdiag for several releases. For the past few releases nova has monkey patched blockdiag to around there global replacement of codec.getreader under python 3. The 2.0.0 release broke how that monkey patching worked and also was the first release in several years. Now that the project is active again we have reported the python 3 issue to the maintainer blockdiag/blockdiag#126 and it has been adressed by blockdiag/blockdiag#129 in 2.0.1 which has now been released. https://pypi.org/project/blockdiag/2.0.1/ This change blacklists 2.0.0. This change does not raise the minimum requirement. Nova can selectively raise its minimum requirement in the future in tree if it chooses to remove support for monkey patching older releases. Other project are recommended to use 2.0.1 or later as this is the first release which is python3 only and is compatible with the sphinx extentions we use without monkey patching. Change-Id: I414d9e604616d49b4456ebc348418e9b1b09058b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #126