Fix deprecation of Pillow ImageDraw textsize() #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pillow has marked ImageDraw.textsize() as deprecated[1] for removal in version 10. This patch updates blockdiag to use the new recommended method for getting the text height and width. [1] https://pillow.readthedocs.io/en/stable/deprecations.html#font-size-and-offset-methods
|
@johnsom there are other deprecated APIs gone with pillow 10, like Would you be able to take a stab at patching blockdiag et al for pillow 10? I'm maintaining the package on Fedora and between this, #159 and my lack of time I'm considering orphaning *diag on Fedora. There has unfortunately been no activity since the 3.0.0 release. |
|
It's not clear to me that this project is maintained now as this PR has not progressed and the last commit was 2021. In my use case, I will be removing blockdiag for our project. |
|
Fair enough, I will orphan *diag on Fedora. |
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 31, 2023
* Update designate from branch 'master'
to 4e7e471760d3df40b3282bf73477fda2d08fb384
- Merge "Replace blockdiag with graphviz"
- Replace blockdiag with graphviz
The python blockdiag module is unmaintained and will likely be removed from distros.[1]
This patch replaces blockdiag with graphviz diagrams.
[1] blockdiag/blockdiag#171
Change-Id: I3a902c60b59071b466e1bf1ec6bda205e58b378c
openstack-mirroring
pushed a commit
to openstack/designate
that referenced
this pull request
Jul 31, 2023
The python blockdiag module is unmaintained and will likely be removed from distros.[1] This patch replaces blockdiag with graphviz diagrams. [1] blockdiag/blockdiag#171 Change-Id: I3a902c60b59071b466e1bf1ec6bda205e58b378c
openstack-mirroring
pushed a commit
to openstack/designate
that referenced
this pull request
Aug 9, 2023
The python blockdiag module is unmaintained and will likely be removed from distros.[1] This patch replaces blockdiag with graphviz diagrams. [1] blockdiag/blockdiag#171 Change-Id: I3a902c60b59071b466e1bf1ec6bda205e58b378c (cherry picked from commit beb79ac)
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 17, 2023
* Update octavia from branch 'master'
to 2e563016ce77617e5416f27ff5800b8821561c25
- Merge "Remove blockdiag from Octavia"
- Remove blockdiag from Octavia
The python blockdiag module is unmaintained and will likely be removed from distros.[1]
This patch removes mention of blockdiag from Octavia as it is unused.
[1] blockdiag/blockdiag#171
Change-Id: I88371364b88bec5f1fd42d6ade8b316be3130f3f
openstack-mirroring
pushed a commit
to openstack/octavia
that referenced
this pull request
Aug 17, 2023
The python blockdiag module is unmaintained and will likely be removed from distros.[1] This patch removes mention of blockdiag from Octavia as it is unused. [1] blockdiag/blockdiag#171 Change-Id: I88371364b88bec5f1fd42d6ade8b316be3130f3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pillow has marked ImageDraw.textsize() as deprecated[1] for removal in version 10. This patch updates blockdiag to use the new recommended method for getting the text height and width.
[1] https://pillow.readthedocs.io/en/stable/deprecations.html#font-size-and-offset-methods