Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database writing multicall #120

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Database writing multicall #120

merged 5 commits into from
Jun 24, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Jun 19, 2024

Database writing multicall

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

It add supports to writing multicall to the DatabaseResolver allowing users to send a batch of requests at one that will be handled by the API.

Related Issue

#119

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@pikonha pikonha added the enhancement New feature or request label Jun 19, 2024
@pikonha pikonha self-assigned this Jun 19, 2024
Base automatically changed from config-deploy to main June 20, 2024 13:24
}: {
domain: DomainData
url: string
message: MessageData
signer: PrivateKeyAccount
multicall?: boolean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a parameter here? My understanding is that a multicall would be treated as another call (setText for example).

@alextnetto alextnetto merged commit 8003a16 into main Jun 24, 2024
1 check passed
@alextnetto alextnetto deleted the feat#119-db-multicall branch June 24, 2024 15:20
@pikonha pikonha mentioned this pull request Jun 25, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants