Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Resolver compliant to EIP-5559 #88

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented May 10, 2024

Database Resolver compliant to EIP-5559

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

It introduces the StorageHandledByOffchainDatabase on the newly added write function of the Database Resolver. This function works the same way as the resolver does for reading calls redirecting any writing call to the external database.

Related Issue

#55

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@pikonha pikonha added the enhancement New feature or request label May 10, 2024
@pikonha pikonha self-assigned this May 10, 2024
Copy link
Member

@LeonardoVieira1630 LeonardoVieira1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, nothing to add.

Base automatically changed from chore#80-deploy-gateway-db to main May 17, 2024 17:32
@pikonha pikonha merged commit a8f6aba into main May 17, 2024
@pikonha pikonha deleted the feat#57-db-contract-eip5559 branch May 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants