Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ERC1155 included in createSwap() scripts #225

Merged
merged 4 commits into from
May 19, 2024

Conversation

blackbeard002
Copy link
Contributor

@blackbeard002 blackbeard002 commented May 17, 2024

closes #212
acceptSwap() isn't specific to a token type, thus no changes in it .
Also added encodeAsset in swapFactory script

Copy link
Member

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes :D

@0xneves 0xneves merged commit b20f395 into blockful-io:revision May 19, 2024
3 checks passed
@blackbeard002 blackbeard002 deleted the createSwapERC1155 branch May 19, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants