Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see Fordefi wallet in demo website #1894

Closed
1 task done
rony-arnac opened this issue Aug 31, 2023 · 9 comments · Fixed by #1895
Closed
1 task done

Cannot see Fordefi wallet in demo website #1894

rony-arnac opened this issue Aug 31, 2023 · 9 comments · Fixed by #1895
Assignees
Labels
bug Something isn't working

Comments

@rony-arnac
Copy link
Contributor

rony-arnac commented Aug 31, 2023

Current Behavior

I went to https://onboard.blocknative.com/examples/connect-wallet and clicked on Connect and I don't see Fordefi wallet.

Here are some prints of my window
image

Expected Behavior

See the wallet in the options.

Steps To Reproduce

No response

What package is effected by this issue?

@web3-onboard/injected

Is this a build or a runtime issue?

N/A

Package Version

"@web3-onboard/injected-wallets": "^2.10.5",

Node Version

No response

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Anything else?

No response

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@rony-arnac rony-arnac added the bug Something isn't working label Aug 31, 2023
@Adamj1232
Copy link
Member

@rony-arnac do you have Fordefi wallet installed on your browser and set to be your primary wallet?

@rony-arnac
Copy link
Contributor Author

@Adamj1232 yep. added prints of my window above

@Adamj1232
Copy link
Member

Are you seeing the same behavior here- https://reactdemo.blocknative.com/
The docs site may need to have its deps updated

@rony-arnac
Copy link
Contributor Author

maybe the issue is that Fordefi uses otherProviderFlagsExist when isMetaMask is true as well?

https://github.com/blocknative/web3-onboard/blob/develop/packages/injected/src/wallets.ts#L822

@Adamj1232
Copy link
Member

Im not too sure, I cant find where I can download the extension to test

@rony-arnac
Copy link
Contributor Author

Are you seeing the same behavior here- https://reactdemo.blocknative.com/ The docs site may need to have its deps updated

image

@Adamj1232
Copy link
Member

Are you a Fordefi dev by chance? Why is isMetaMask marked as true?

@rony-arnac
Copy link
Contributor Author

rony-arnac commented Aug 31, 2023

Are you a Fordefi dev by chance? Why is isMetaMask marked as true?

We use their open source provider..
I think this is a bug in the code I pushed. I need to remove otherProviderFlagsExist

@rony-arnac
Copy link
Contributor Author

yep, will create a PR to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants