-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade next-mdx-remote
and other markdown-related dependencies
#321
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
294e14e
Upgrade and other markdown-related dependencies
kachkaev 66a5cf9
Merge remote-tracking branch 'origin/main' into ak/upgrade-next-mdx-r…
kachkaev 310c747
Dedupe
kachkaev a020be5
Remove comment
kachkaev 5b66739
Remove MDX comment
kachkaev 9f7672a
Merge remote-tracking branch 'origin/main' into ak/upgrade-next-mdx-r…
kachkaev c23843b
Fix code and inline code
kachkaev 059a21d
ESMify
kachkaev 2faf6b4
Reduce diff (?)
kachkaev dd977ba
Reduce diff again (?)
kachkaev a53000b
Fix typings
kachkaev f3fd11b
Merge branch 'main' into ak/upgrade-next-mdx-remote
kachkaev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,11 +3,10 @@ import matter from "gray-matter"; | |
import { MDXRemoteSerializeResult } from "next-mdx-remote"; | ||
import { serialize } from "next-mdx-remote/serialize"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was impossible without #322 because |
||
import path from "node:path"; | ||
// @ts-expect-error -- Need to figure out how to get or declare the necessary types | ||
import remarkMdx from "remark-mdx"; | ||
import remarkParse from "remark-parse"; | ||
import slugify from "slugify"; | ||
import unified from "unified"; | ||
import { unified } from "unified"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Breaking change in unified |
||
|
||
import { SiteMapPage, SiteMapPageSection } from "../lib/sitemap"; | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MDX 2 requires comments to be in
{* *}
instead of<!-- -->
, which Prettier does on like. Upstream issues: prettier/prettier#12209 / hashicorp/next-mdx-remote#277In the meantime, if we do need to disable a markdownlint rule, we can do so in
.markdownlint.json
. I switched to regular MD headers here to avoid that. The text is a bit bigger than before but the doc looks good overall.