Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passport to 0.6.0 #502

Closed
wants to merge 2 commits into from
Closed

Update passport to 0.6.0 #502

wants to merge 2 commits into from

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Aug 16, 2022

Blocked by jaredhanson/passport#904


@github-actions github-actions bot added area: dependencies Relates to third-party or otherwise imported dependencies (area) area: infra Relates to version control, CI, CD or IaC (area) area: apps > site The blockprotocol.org website, inc. Hub (app) labels Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #502 (04bb7e4) into main (d55281a) will decrease coverage by 12.53%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #502       +/-   ##
===========================================
- Coverage   62.62%   50.08%   -12.54%     
===========================================
  Files         229      228        -1     
  Lines        3748     3718       -30     
  Branches      903      897        -6     
===========================================
- Hits         2347     1862      -485     
- Misses       1103     1630      +527     
+ Partials      298      226       -72     
Flag Coverage Δ
site-integration 50.08% <0.00%> (-12.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
site/src/lib/api/middleware/passport.middleware.ts 42.85% <ø> (-57.15%) ⬇️
site/src/pages/api/logout.api.ts 0.00% <0.00%> (-100.00%) ⬇️
site/src/pages/api/me.api.ts 0.00% <0.00%> (-100.00%) ⬇️
site/src/pages/api/me/api-keys.api.ts 0.00% <0.00%> (-100.00%) ⬇️
...te/src/lib/api/handler/api-key-required-handler.ts 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/pages/dashboard/api-key-renderer.tsx 8.33% <0.00%> (-91.67%) ⬇️
...lib/api/middleware/has-valid-api-key.middleware.ts 0.00% <0.00%> (-90.00%) ⬇️
.../components/pages/dashboard/generate-api-modal.tsx 5.26% <0.00%> (-89.48%) ⬇️
site/src/pages/api/types/create.api.ts 0.00% <0.00%> (-85.72%) ⬇️
site/src/pages/settings/api-keys.page.tsx 4.76% <0.00%> (-85.72%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vilkinsons
Copy link
Contributor

@kachkaev There is now a workaround/fix to silence the Dependabot security flag, which we could look into using until such time as this dependency gets upgraded: jaredhanson/passport#904 (comment)

@kachkaev
Copy link
Contributor Author

I don't know enough about passport to confirm if we need that patch or not. We could add it nevertheless next sprint if you think that it's worthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: apps > site The blockprotocol.org website, inc. Hub (app) area: dependencies Relates to third-party or otherwise imported dependencies (area) area: infra Relates to version control, CI, CD or IaC (area)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants