Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks need to be imported when generating new code #52

Closed
johno opened this issue Nov 25, 2019 · 0 comments · Fixed by #138
Closed

Blocks need to be imported when generating new code #52

johno opened this issue Nov 25, 2019 · 0 comments · Fixed by #138
Assignees
@johno
Labels
💻 editor JSX-based page builder 🚦 high-priority Let's address this ASAP
Projects
Roadmap

Comments

@johno
Copy link
Member

johno commented Nov 25, 2019

When generating the modified code to return, we need to automatically add imports for any components that may have been added. We also need to remove existing imports for those that may have been removed.
@johno johno added 🚦 high-priority Let's address this ASAP 💻 editor JSX-based page builder labels Nov 25, 2019
@johno johno added this to In progress in Roadmap Dec 1, 2019
@johno johno self-assigned this Dec 1, 2019
johno added a commit that referenced this issue Dec 3, 2019
@johno
Update block imports when they're added or removed
11fa112 
Closes #52
@johno johno mentioned this issue Dec 3, 2019
Merged
johno added a commit that referenced this issue Dec 3, 2019
@johno
Update block imports when they're added or removed
49c7a65 
Closes #52
@johno johno closed this as completed in #138 Dec 3, 2019
Roadmap automation moved this from In progress to Done Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johno johno

Labels
💻 editor JSX-based page builder 🚦 high-priority Let's address this ASAP
Projects
Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update block imports when they're added or removed blocks/blocks
1 participant
@johno