Merge pull request #3607 from poanetwork/vb-contract-reader-fix

Process :bool, :string types in contract together with  string representations

CHANGELOG.md

@@ -8,7 +8,7 @@
 
 ### Fixes
 - [#3600](https://github.com/poanetwork/blockscout/pull/3600) - Prevent update validator metadata with empty name from contract
-- [#3592](https://github.com/poanetwork/blockscout/pull/3592), [#3601](https://github.com/poanetwork/blockscout/pull/3601) - Contract interaction: fix nested tuples in the output view, add formatting
+- [#3592](https://github.com/poanetwork/blockscout/pull/3592), [#3601](https://github.com/poanetwork/blockscout/pull/3601), [#3607](https://github.com/poanetwork/blockscout/pull/3607) - Contract interaction: fix nested tuples in the output view, add formatting
 - [#3583](https://github.com/poanetwork/blockscout/pull/3583) - Reduce RPC requests and DB changes by Staking DApp
 - [#3577](https://github.com/poanetwork/blockscout/pull/3577) - Eliminate GraphiQL page XSS attack
 

apps/block_scout_web/lib/block_scout_web/views/smart_contract_view.ex

@@ -100,8 +100,12 @@ defmodule BlockScoutWeb.SmartContractView do
 
   def values_with_type(value, "string", _components), do: render_type_value("string", value)
 
+  def values_with_type(value, :string, _components), do: render_type_value("string", value)
+
   def values_with_type(value, "bool", _components), do: render_type_value("bool", to_string(value))
 
+  def values_with_type(value, :bool, _components), do: render_type_value("bool", to_string(value))
+
   def values_with_type(value, type, _components) do
     if String.starts_with?(type, "uint") do
       render_type_value(type, to_string(value))
@@ -166,8 +170,12 @@ defmodule BlockScoutWeb.SmartContractView do
 
   def values_only(value, "string", _components), do: value
 
+  def values_only(value, :string, _components), do: value
+
   def values_only(value, "bool", _components), do: to_string(value)
 
+  def values_only(value, :bool, _components), do: to_string(value)
+
   def values_only(value, type, _components) do
     if String.starts_with?(type, "uint") do
       to_string(value)

apps/block_scout_web/test/block_scout_web/views/tokens/smart_contract_view_test.exs

@@ -280,12 +280,24 @@ defmodule BlockScoutWeb.SmartContractViewTest do
       assert SmartContractView.values_only(value, "string", nil) == "POA"
     end
 
+    test "returns the value when the type is :string" do
+      value = "POA"
+
+      assert SmartContractView.values_only(value, :string, nil) == "POA"
+    end
+
     test "returns the value when the type is boolean" do
       value = "true"
 
       assert SmartContractView.values_only(value, "bool", nil) == "true"
     end
 
+    test "returns the value when the type is :bool" do
+      value = "true"
+
+      assert SmartContractView.values_only(value, :bool, nil) == "true"
+    end
+
     test "returns the value when the type is bytes4" do
       value = <<228, 184, 12, 77>>