Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility in verification form: label associations are broken #6463

Closed
lukaw3d opened this issue Nov 16, 2022 · 1 comment · Fixed by #6481
Closed

Accessibility in verification form: label associations are broken #6463

lukaw3d opened this issue Nov 16, 2022 · 1 comment · Fixed by #6481
Assignees

Comments

@lukaw3d
Copy link

lukaw3d commented Nov 16, 2022

Labels and inputs in contract verification form are not associated correctly.

For example https://blockscout.com/eth/mainnet/address/0xcDA72070E455bb31C7690a170224Ce43623d0B6f/verify-via-flattened-code/new at least these elements reference elements that don't exist:

<input aria-describedby="contract-name-help-block" ..>
<label for="smart_contract_Include nightly builds">Include nightly builds</label>
<label class="radio-text" for="nightly_builds_false">No</label>
<label for="evm_version_evm_version">EVM Version</label>
<label for="smart_contract_Optimization">Optimization</label>
<label for="smart_contract_name">Optimization runs</label> <!-- in this case element exists, but it's wrong -->
<label for="external_libraries_library1">Library 1 Name</label>

Environment

  • Deployment type (Manual/Docker/Docker-compose):
  • Elixir & Erlang/OTP versions (elixir -version):
  • Node JS version (node -v):
  • Operating System:
  • Blockscout Version/branch/commit: v4.1.8-beta
  • Archive node type && version (Erigon/Geth/Nethermind/Ganache/?):

Steps to reproduce

Open https://blockscout.com/eth/mainnet/address/0xcDA72070E455bb31C7690a170224Ce43623d0B6f/verify-via-flattened-code/new and click on various input labels.

Expected behaviour

Referenced elements should exist and clicking on input labels should focus the associated input.

Actual behaviour

"Optimization runs" label references contract name input. Some other labels reference elements that don't exist
labels

@vbaranov
Copy link
Member

@lukaw3d nice catch. We will take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants