Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart contract verification improvements #6481

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Nov 20, 2022

Close #5675
Close #6463
Close #5746
Close #4571

Motivation

Changelog

  • Refactor smart contract verification form
  • Add support for smart contract verification without creation bytecode (with smart contract verifier)
  • Add compiler settings for smart contracts verified via standard JSON input or Sourcify
  • Add compiler_settings field to smart_contracts table
  • Add verified twin name as fallback name for unverified contract

Checklist for your Pull Request (PR)

@nikitosing nikitosing changed the title Refactor smart contract verification form; Add support for smart cont… Smart contract verification improvements Nov 20, 2022
@nikitosing nikitosing temporarily deployed to Dev November 21, 2022 08:31 Inactive
@nikitosing nikitosing temporarily deployed to Dev November 21, 2022 13:55 Inactive
@nikitosing nikitosing temporarily deployed to Dev November 21, 2022 17:58 Inactive
@nikitosing nikitosing temporarily deployed to Dev November 21, 2022 19:55 Inactive
@nikitosing nikitosing temporarily deployed to Dev November 22, 2022 08:36 Inactive
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitosing label association is still broken

  • for Compiler field atverify-via-standard-json-input/new
  • for Compiler field at verify-via-multi-part-files/new

@vbaranov vbaranov temporarily deployed to Tests November 28, 2022 09:57 Inactive
@nikitosing nikitosing temporarily deployed to Tests November 28, 2022 10:45 Inactive
@vbaranov vbaranov merged commit a63db41 into master Nov 28, 2022
@vbaranov vbaranov deleted the np-smart-contract-fixes branch November 28, 2022 11:34
cedricfung pushed a commit to MixinNetwork/blockscout that referenced this pull request Dec 2, 2022
* Refactor smart contract verification form; Add support for smart contract verification without creation bytecode

* Add compiler settings for smart contracts verified via standard JSON input or Sourcify

* Add verified twin name as fallback name for unverified contract; Fix compiler label
fx0x55 pushed a commit to FunctionX/blockscout that referenced this pull request Feb 9, 2023
* Refactor smart contract verification form; Add support for smart contract verification without creation bytecode

* Add compiler settings for smart contracts verified via standard JSON input or Sourcify

* Add verified twin name as fallback name for unverified contract; Fix compiler label

(cherry picked from commit a63db41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants