Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FunctionClauseError caused by blockTimestamp in reth v0.2.0-beta.6 #10085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dirname
Copy link

@dirname dirname commented May 18, 2024

Motivation

In reth v0.2.0-beta.6, the blockTimestamp was added to the meta information (see commit ca82ff5). This change leads to an error:

(FunctionClauseError) no function clause matching in EthereumJSONRPC.Log.entry_to_elixir/1
(ethereum_jsonrpc 6.5.0) lib/ethereum_jsonrpc/log.ex:165: EthereumJSONRPC.Log.entry_to_elixir({"blockTimestamp", "0x6647620b"})

This PR addresses and resolves the issue by ensuring proper handling of the blockTimestamp in the eth_getTransactionReceipt function.

Changelog

Enhancements

  • Added handling for blockTimestamp in the eth_getTransactionReceipt function to prevent errors when parsing logs.

Bug Fixes

  • Fixed the (FunctionClauseError) no function clause matching in EthereumJSONRPC.Log.entry_to_elixir/1 error caused by the inclusion of blockTimestamp in the meta information.

Incompatible Changes

  • None

Upgrading

  • No special upgrade steps are required.

Checklist for your Pull Request (PR)

Copy link
Collaborator

@fedor-ivn fedor-ivn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I left one suggestion, but overall LGTM.

@fedor-ivn
Copy link
Collaborator

@dirname I've run the CI/CD. Please check the job logs, seems like your fix caused some tests to fail, so they need some adjustments.

@dirname
Copy link
Author

dirname commented May 20, 2024

@dirname I've run the CI/CD. Please check the job logs, seems like your fix caused some tests to fail, so they need some adjustments.

Thank you for your meticulous attention to the code. I have taken the following steps to confirm with high probability that the CI failure is not related to the changes in this PR:

  1. I downloaded the failed CI logs and did not find any calls related to the changes in this PR in the thrown stack.

  2. Due to the extensive content of the logs, I used AI to assist in summarizing the errors, which are mainly due to:

Screenshot 2024-05-20 231022 Screenshot 2024-05-20 232251
  1. I reviewed the CI records prior to this change and found similar errors to the ones seen in the current CI failure.

Please let me know if there's anything else need to explore or adjust.

@fedor-ivn
Copy link
Collaborator

@dirname, my apologies for the confusion. The test failures indeed don't seem to be related to your changes. They might be due to a flaky test. I'll investigate further and update you soon.

@fedor-ivn fedor-ivn self-requested a review May 21, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants